Fix niggles found by go vet

shalupov · Feb 28, 2015 · fe68737 · fe68737
1 parent 2360bf9
commit fe68737
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/drive/drive.go b/drive/drive.go
@@ -76,7 +76,7 @@ type FsDrive struct {
 	rootId       string         // Id of the root directory
 	foundRoot    bool           // Whether we have found the root or not
 	findRootLock sync.Mutex     // Protect findRoot from concurrent use
-	dirCache     dirCache       // Map of directory path to directory id
+	dirCache     *dirCache      // Map of directory path to directory id
 	findDirLock  sync.Mutex     // Protect findDir from concurrent use
 	pacer        chan struct{}  // To pace the operations
 	sleepTime    time.Duration  // Time to sleep for each transaction
@@ -101,8 +101,8 @@ type dirCache struct {
 }
 
 // Make a new locked map
-func newDirCache() dirCache {
-	d := dirCache{}
+func newDirCache() *dirCache {
+	d := &dirCache{}
 	d.Flush()
 	return d
 }

diff --git a/fs/config.go b/fs/config.go
@@ -61,7 +61,6 @@ func (x *SizeSuffix) String() string {
 	default:
 		return fmt.Sprintf("%.3fG", float64(*x)/1024/1024/1024)
 	}
-	panic("shouldn't be reached")
 }
 
 // Set a SizeSuffix

diff --git a/fstest/fstests/fstests.go b/fstest/fstests/fstests.go
@@ -109,7 +109,7 @@ func TestFsListEmpty(t *testing.T) {
 func TestFsListDirEmpty(t *testing.T) {
 	skipIfNotOk(t)
 	for obj := range remote.ListDir() {
-		t.Error("Found unexpected item %q", obj.Name)
+		t.Errorf("Found unexpected item %q", obj.Name)
 	}
 }
 
@@ -174,7 +174,7 @@ func TestFsListDirRoot(t *testing.T) {
 	skipIfNotOk(t)
 	rootRemote, err := fs.NewFs(RemoteName)
 	if err != nil {
-		t.Fatal("Failed to make remote %q: %v", RemoteName, err)
+		t.Fatalf("Failed to make remote %q: %v", RemoteName, err)
 	}
 	found := false
 	for obj := range rootRemote.ListDir() {
@@ -191,7 +191,7 @@ func TestFsListRoot(t *testing.T) {
 	skipIfNotOk(t)
 	rootRemote, err := fs.NewFs(RemoteName)
 	if err != nil {
-		t.Fatal("Failed to make remote %q: %v", RemoteName, err)
+		t.Fatalf("Failed to make remote %q: %v", RemoteName, err)
 	}
 	// Should either find file1 and file2 or nothing
 	found1 := false
@@ -384,7 +384,7 @@ func TestLimitedFs(t *testing.T) {
 	file2Copy.Path = "z.txt"
 	fileRemote, err := fs.NewFs(remoteName)
 	if err != nil {
-		t.Fatal("Failed to make remote %q: %v", remoteName, err)
+		t.Fatalf("Failed to make remote %q: %v", remoteName, err)
 	}
 	fstest.CheckListing(t, fileRemote, []fstest.Item{file2Copy})
 	_, ok := fileRemote.(*fs.Limited)
@@ -398,7 +398,7 @@ func TestLimitedFsNotFound(t *testing.T) {
 	remoteName := subRemoteName + "/not found.txt"
 	fileRemote, err := fs.NewFs(remoteName)
 	if err != nil {
-		t.Fatal("Failed to make remote %q: %v", remoteName, err)
+		t.Fatalf("Failed to make remote %q: %v", remoteName, err)
 	}
 	fstest.CheckListing(t, fileRemote, []fstest.Item{})
 	_, ok := fileRemote.(*fs.Limited)