Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several fixes and additions #153

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Several fixes and additions #153

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5d28d55
fix insert array type
Feb 21, 2024
afc3881
testing type conversions
Plozano94 Feb 22, 2024
b43d7a7
Giving up in Any Of case
Plozano94 Feb 23, 2024
1c79aa0
added test for all types column
Feb 23, 2024
045da20
Overwritting conform_name
Plozano94 Feb 23, 2024
ba343ba
Merge pull request #1 from gallejesus/fix-arrays
gallejesus Feb 26, 2024
23d5104
Fixing decimal
Plozano94 Feb 27, 2024
3784e24
Merge pull request #2 from gallejesus/bugfix/decimal
gallejesus Feb 27, 2024
fff5a84
skip activate_version if metadata not added
Feb 29, 2024
3d2154a
Merge pull request #3 from gallejesus/skip-activate_version
gallejesus Feb 29, 2024
c7538cd
fix decimals
Mar 1, 2024
5188368
Merge pull request #4 from gallejesus/fix-decimals
gallejesus Mar 1, 2024
6408673
Merge branch 'main' into merge-origin
Apr 15, 2024
2714fb3
fix tests naming
Apr 15, 2024
729801c
add all_types suitetest
Apr 15, 2024
a80403d
remove all datetimes nullable?
Apr 15, 2024
8a0ce4d
Merge pull request #6 from gallejesus/merge-origin
gallejesus Apr 16, 2024
ac612c7
use type Date32 for dates in ch
May 21, 2024
d7ff030
Merge branch 'main' into main
gallejesus May 21, 2024
863eeb4
poetry from remote
May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing decimal
  • Loading branch information
@Plozano94
Plozano94 committed Feb 27, 2024
commit 23d51040f5fd98275a79df8c48e7230fbbb16804
2 changes: 1 addition & 1 deletion target_clickhouse/connectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def nullabilizer(jsonschema_type: dict, type: sqlalchemy.types.TypeEngine):
if th._jsonschema_type_check(jsonschema_type, ("integer",)):
return nullabilizer(jsonschema_type, t.cast(sqlalchemy.types.TypeEngine, sqlalchemy.types.INTEGER()))
if th._jsonschema_type_check(jsonschema_type, ("number",)):
return nullabilizer(jsonschema_type, t.cast(sqlalchemy.types.TypeEngine, sqlalchemy.types.DECIMAL()))
return nullabilizer(jsonschema_type, t.cast(sqlalchemy.types.TypeEngine, sqlalchemy.types.FLOAT()))
if th._jsonschema_type_check(jsonschema_type, ("boolean",)):
return nullabilizer(jsonschema_type, t.cast(sqlalchemy.types.TypeEngine, sqlalchemy.types.BOOLEAN()))

Expand Down