Skip to content

Commit

Permalink
fix(Toolbox): Fix toolbox display when accessing it via keyboard
Browse files Browse the repository at this point in the history
  • Loading branch information
muscat1 authored Jan 15, 2021
1 parent b65e61f commit 8aae206
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion react/features/toolbox/components/web/Toolbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ import {
import {
setFullScreen,
setOverflowMenuVisible,
setToolbarHovered
setToolbarHovered,
setToolboxVisible
} from '../../actions';
import { isToolboxVisible } from '../../functions';
import DownloadButton from '../DownloadButton';
Expand Down Expand Up @@ -238,6 +239,7 @@ class Toolbox extends Component<Props, State> {
this._onMouseOver = this._onMouseOver.bind(this);
this._onResize = this._onResize.bind(this);
this._onSetOverflowVisible = this._onSetOverflowVisible.bind(this);
this._onTabIn = this._onTabIn.bind(this);

this._onShortcutToggleChat = this._onShortcutToggleChat.bind(this);
this._onShortcutToggleFullScreen = this._onShortcutToggleFullScreen.bind(this);
Expand Down Expand Up @@ -368,6 +370,7 @@ class Toolbox extends Component<Props, State> {
<div
className = { rootClassNames }
id = 'new-toolbox'
onFocus = { this._onTabIn }
onMouseOut = { this._onMouseOut }
onMouseOver = { this._onMouseOver }>
<div className = 'toolbox-background' />
Expand Down Expand Up @@ -698,6 +701,19 @@ class Toolbox extends Component<Props, State> {
this._doToggleScreenshare();
}

_onTabIn: () => void;

/**
* Toggle the toolbar visibility when tabbing into it.
*
* @returns {void}
*/
_onTabIn() {
if (!this.props._visible) {
this.props.dispatch(setToolboxVisible(true));
}
}

_onToolbarOpenFeedback: () => void;

/**
Expand Down

0 comments on commit 8aae206

Please sign in to comment.