Merge pull request bcit-ci#5531 from tianhe1986/develop_input_array_n…

…otation Input: considering nested array keys in `get_post` and `post_get`
shawe · Jul 22, 2018 · 29b2ac0 · 29b2ac0
2 parents d0d4548 + 8258435
commit 29b2ac0
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 6 deletions.
diff --git a/system/core/Input.php b/system/core/Input.php
@@ -212,9 +212,8 @@ public function post($index = NULL, $xss_clean = FALSE)
 	 */
 	public function post_get($index, $xss_clean = FALSE)
 	{
-		return isset($_POST[$index])
-			? $this->post($index, $xss_clean)
-			: $this->get($index, $xss_clean);
+		$output = $this->post($index, $xss_clean);
+		return isset($output) ? $output : $this->get($index, $xss_clean);
 	}
 
 	// --------------------------------------------------------------------
@@ -228,9 +227,8 @@ public function post_get($index, $xss_clean = FALSE)
 	 */
 	public function get_post($index, $xss_clean = FALSE)
 	{
-		return isset($_GET[$index])
-			? $this->get($index, $xss_clean)
-			: $this->post($index, $xss_clean);
+		$output = $this->get($index, $xss_clean);
+		return isset($output) ? $output : $this->post($index, $xss_clean);
 	}
 
 	// --------------------------------------------------------------------

diff --git a/tests/codeigniter/core/Input_test.php b/tests/codeigniter/core/Input_test.php
@@ -90,6 +90,23 @@ public function test_post_get()
 
 	// --------------------------------------------------------------------
 
+	public function test_post_get_array_notation()
+	{
+		$_SERVER['REQUEST_METHOD'] = 'POST';
+		$_POST['foo']['bar'] = 'baz';
+		$barArray = array('bar' => 'baz');
+
+		$this->assertEquals('baz', $this->input->get_post('foo[bar]'));
+		$this->assertEquals($barArray, $this->input->get_post('foo[]'));
+		$this->assertNull($this->input->get_post('foo[baz]'));
+
+		$this->assertEquals('baz', $this->input->post_get('foo[bar]'));
+		$this->assertEquals($barArray, $this->input->post_get('foo[]'));
+		$this->assertNull($this->input->post_get('foo[baz]'));
+	}
+
+	// --------------------------------------------------------------------
+
 	public function test_get_post()
 	{
 		$_SERVER['REQUEST_METHOD'] = 'GET';
@@ -100,6 +117,23 @@ public function test_get_post()
 
 	// --------------------------------------------------------------------
 
+	public function test_get_post_array_notation()
+	{
+		$_SERVER['REQUEST_METHOD'] = 'GET';
+		$_GET['foo']['bar'] = 'baz';
+		$barArray = array('bar' => 'baz');
+
+		$this->assertEquals('baz', $this->input->get_post('foo[bar]'));
+		$this->assertEquals($barArray, $this->input->get_post('foo[]'));
+		$this->assertNull($this->input->get_post('foo[baz]'));
+
+		$this->assertEquals('baz', $this->input->post_get('foo[bar]'));
+		$this->assertEquals($barArray, $this->input->post_get('foo[]'));
+		$this->assertNull($this->input->post_get('foo[baz]'));
+	}
+
+	// --------------------------------------------------------------------
+
 	public function test_cookie()
 	{
 		$_COOKIE['foo'] = 'bar';