Add missing overrides and missing virtual destructor

shengyenlo · Nov 8, 2018 · 78e61ee · 78e61ee
1 parent 83700eb
commit 78e61ee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/ui/colormaps.h b/src/ui/colormaps.h
@@ -44,6 +44,7 @@ namespace colmap {
 class PointColormapBase {
  public:
   PointColormapBase();
+  virtual ~PointColormapBase() = default;
 
   virtual void Prepare(EIGEN_STL_UMAP(camera_t, Camera) & cameras,
                        EIGEN_STL_UMAP(image_t, Image) & images,
@@ -70,7 +71,7 @@ class PointColormapPhotometric : public PointColormapBase {
   void Prepare(EIGEN_STL_UMAP(camera_t, Camera) & cameras,
                EIGEN_STL_UMAP(image_t, Image) & images,
                EIGEN_STL_UMAP(point3D_t, Point3D) & points3D,
-               std::vector<image_t>& reg_image_ids);
+               std::vector<image_t>& reg_image_ids) override;
 
   Eigen::Vector4f ComputeColor(const point3D_t point3D_id,
                                const Point3D& point3D) override;
@@ -82,7 +83,7 @@ class PointColormapError : public PointColormapBase {
   void Prepare(EIGEN_STL_UMAP(camera_t, Camera) & cameras,
                EIGEN_STL_UMAP(image_t, Image) & images,
                EIGEN_STL_UMAP(point3D_t, Point3D) & points3D,
-               std::vector<image_t>& reg_image_ids);
+               std::vector<image_t>& reg_image_ids) override;
 
   Eigen::Vector4f ComputeColor(const point3D_t point3D_id,
                                const Point3D& point3D) override;
@@ -94,7 +95,7 @@ class PointColormapTrackLen : public PointColormapBase {
   void Prepare(EIGEN_STL_UMAP(camera_t, Camera) & cameras,
                EIGEN_STL_UMAP(image_t, Image) & images,
                EIGEN_STL_UMAP(point3D_t, Point3D) & points3D,
-               std::vector<image_t>& reg_image_ids);
+               std::vector<image_t>& reg_image_ids) override;
 
   Eigen::Vector4f ComputeColor(const point3D_t point3D_id,
                                const Point3D& point3D) override;
@@ -106,7 +107,7 @@ class PointColormapGroundResolution : public PointColormapBase {
   void Prepare(EIGEN_STL_UMAP(camera_t, Camera) & cameras,
                EIGEN_STL_UMAP(image_t, Image) & images,
                EIGEN_STL_UMAP(point3D_t, Point3D) & points3D,
-               std::vector<image_t>& reg_image_ids);
+               std::vector<image_t>& reg_image_ids) override;
 
   Eigen::Vector4f ComputeColor(const point3D_t point3D_id,
                                const Point3D& point3D) override;
@@ -119,6 +120,7 @@ class PointColormapGroundResolution : public PointColormapBase {
 class ImageColormapBase {
  public:
   ImageColormapBase();
+  virtual ~ImageColormapBase() = default;
 
   virtual void Prepare(EIGEN_STL_UMAP(camera_t, Camera) & cameras,
                        EIGEN_STL_UMAP(image_t, Image) & images,

diff --git a/src/util/cache.h b/src/util/cache.h
@@ -47,6 +47,7 @@ class LRUCache {
  public:
   LRUCache(const size_t max_num_elems,
            const std::function<value_t(const key_t&)>& getter_func);
+  virtual ~LRUCache() = default;
 
   // The number of elements in the cache.
   size_t NumElems() const;