Skip to content

Commit

Permalink
remove redundant condition from private module use warning
Browse files Browse the repository at this point in the history
the whole point of the check is ensuring that the message is printed
only once for each sub-project, so !build_pass alone is fully adequate.

Change-Id: Ib8f821ead6709efc9bfa935e1d05f8caba02a814
Reviewed-by: Jake Petroules <[email protected]>
  • Loading branch information
ossilator committed Jul 13, 2016
1 parent 3c81349 commit fc57a65
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mkspecs/features/qt.prf
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ for(ever) {
!isEmpty(var_sfx): break()
var_sfx = _PRIVATE
}
!isEmpty(using_privates):!no_private_qt_headers_warning:if(!debug_and_release|!build_pass) {
!isEmpty(using_privates):!no_private_qt_headers_warning:!build_pass {
message("This project is using private headers and will therefore be tied to this specific Qt module build version.")
message("Running this project against other versions of the Qt modules may crash at any arbitrary point.")
message("This is not a bug, but a result of using Qt internals. You have been warned!")
Expand Down

0 comments on commit fc57a65

Please sign in to comment.