-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/disable shipping methods on paypal #191
base: master
Are you sure you want to change the base?
Conversation
…tcommerce/flex-ruby-gem into feature/disable_shipping_methods_on_paypal
# This class is used while setting up the paypal for FE | ||
# It deals with line items total, sub total, tax calculations and | ||
# Also deals with discounted line items and discounts inorder to send to paypal | ||
# | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class also does something for gift cards now; it might need to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It's simply subtracting gift card amount from total amount but I will update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed with comments, but obviously its code already in production for some months. I am not sure my review would add very much value.
Co-authored-by: Simon <[email protected]>
…hiftcommerce/flex-ruby-gem into feature/disable_shipping_methods_on_paypal
This PR: