Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/disable shipping methods on paypal #191

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

praweb
Copy link
Contributor

@praweb praweb commented Mar 24, 2020

This PR:

  • Adds gift card amount to paypal payments to allow for partial payments.
  • Adds filtering for disable shipping methods to facilitate for the use cases of disabling shipping methods e.g C&C due to COVID-19 response.

# This class is used while setting up the paypal for FE
# It deals with line items total, sub total, tax calculations and
# Also deals with discounted line items and discounts inorder to send to paypal
#
#

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class also does something for gift cards now; it might need to be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's simply subtracting gift card amount from total amount but I will update it.

Copy link

@simonireilly simonireilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed with comments, but obviously its code already in production for some months. I am not sure my review would add very much value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants