Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clicking on search result from same page doesn't scroll to the heading #4048

Merged
merged 19 commits into from
Jan 25, 2025
Merged

fix clicking on search result from same page doesn't scroll to the heading #4048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
57b4da0
upd
dimaMachina Jan 24, 2025
e3803f1
upd
dimaMachina Jan 24, 2025
199fccb
upd
dimaMachina Jan 24, 2025
4e76a99
upd
dimaMachina Jan 24, 2025
2cc5ef1
upd
dimaMachina Jan 24, 2025
fe04427
upd
dimaMachina Jan 24, 2025
0e92729
upd
dimaMachina Jan 24, 2025
c61a4d3
upd
dimaMachina Jan 24, 2025
b17477e
upd
dimaMachina Jan 24, 2025
25ab91b
upd
dimaMachina Jan 24, 2025
44451b6
upd
dimaMachina Jan 24, 2025
ce7fd83
upd
dimaMachina Jan 24, 2025
7996f24
upd
dimaMachina Jan 24, 2025
bdf90c9
Apply suggestions from code review
dimaMachina Jan 24, 2025
c5e2c55
upd
dimaMachina Jan 24, 2025
256c0ee
upd
dimaMachina Jan 25, 2025
71f15a6
Merge branch 'main' into v4-119
dimaMachina Jan 25, 2025
c1bf031
upd
dimaMachina Jan 25, 2025
79e3978
upd
dimaMachina Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
upd
  • Loading branch information
@dimaMachina
dimaMachina committed Jan 24, 2025
commit b17477ef458e3d3ca77f31e3682084cb7357e189
13 changes: 8 additions & 5 deletions packages/nextra/src/client/components/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,14 @@ export const Search: FC<SearchProps> = ({
return
}
}
const { results } =
await window.pagefind!.debouncedSearch<PagefindResult>(
value,
searchOptions
)
const response = await window.pagefind!.debouncedSearch<PagefindResult>(
value,
searchOptions
)
if (!response) return

const { results } = response

const data = await Promise.all(results.map(o => o.data()))

setResults(
Expand Down
24 changes: 18 additions & 6 deletions packages/nextra/src/server/__tests__/compile.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,9 @@ describe('Code block', () => {
<h3
id="pnpm"
style={{
display: 'none'
visibility: 'hidden',
height: 0,
width: 0
}}
>
{'pnpm'}
Expand All @@ -652,7 +654,9 @@ describe('Code block', () => {
<h3
id="npm"
style={{
display: 'none'
visibility: 'hidden',
height: 0,
width: 0
}}
>
{'npm'}
Expand All @@ -665,7 +669,9 @@ describe('Code block', () => {
<h3
id="yarn"
style={{
display: 'none'
visibility: 'hidden',
height: 0,
width: 0
}}
>
{'yarn'}
Expand All @@ -681,7 +687,9 @@ describe('Code block', () => {
<h3
id="pnpm-1"
style={{
display: 'none'
visibility: 'hidden',
height: 0,
width: 0
}}
>
{'pnpm'}
Expand All @@ -694,7 +702,9 @@ describe('Code block', () => {
<h3
id="npm-1"
style={{
display: 'none'
visibility: 'hidden',
height: 0,
width: 0
}}
>
{'npm'}
Expand All @@ -707,7 +717,9 @@ describe('Code block', () => {
<h3
id="yarn-1"
style={{
display: 'none'
visibility: 'hidden',
height: 0,
width: 0
}}
>
{'yarn'}
Expand Down