Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LineTable search #13

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Fix LineTable search #13

merged 3 commits into from
Feb 4, 2020

Conversation

FirehaK
Copy link

@FirehaK FirehaK commented Jan 28, 2020

Gopclntab.findGoPcLn() now performs a search across the entire binary instead of only searching IDA defined functions. This fixes #11 where in some cases the plugin was unable to find the LineTable.

Stephan Simon added 2 commits January 28, 2020 15:24
Perform LineTable search over entire binary
e71fc83 
Gopclntab.findGoPcLn() now performs a search across the entire binary instead of only searching IDA defined functions. This fixes some cases where the plugin was unable to find the LineTable
Remove leftover debugging
58865f9 
Removed some debugging I accidentally left in the previous commit
@FirehaK FirehaK changed the title Ida 7.4 python2 Error finding LineTable in some binaries Jan 28, 2020
@FirehaK FirehaK changed the title Error finding LineTable in some binaries Fix LineTable search Jan 28, 2020
@grokeus
Copy link
Collaborator

grokeus commented Jan 28, 2020

Hi!
hmm, look like this code won't work if "lookup" exist in binary as some data?
I mean that we probably should try to keep searching while find_data will return BADDADDR or we find pclntab
so we should calculate end_ea out of loop(actually looks like get_segm_end(0) returning idc.BADADDR, so we can just pass BADADDR as second argument)

@grokeus grokeus merged commit 8e063fd into sibears:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error finding LineTable in some binaries
2 participants
@FirehaK @grokeus