Skip to content

Commit

Permalink
Fixed CI/CD workflow for issue bregman-arie#182 / bregman-arie#232 (b…
Browse files Browse the repository at this point in the history
…regman-arie#254)

* updated the CI/CD workflow so it works

* fixing typos

* changed the branch name for the CI pull request

* fixing PEP8 issues inside binary_search.py

* removed venv from flask8 local testing

* fixing executable permissions
  • Loading branch information
Lewis Brogan authored Jun 27, 2022
1 parent 080c538 commit 84640e8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
18 changes: 6 additions & 12 deletions .github/workflows/ci_workflow.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,18 @@
name: CI

on:
# Triggers the workflow on pull request events for the main and devel branch
pull_request:
branches: [ main, devel ]

# Allows running this workflow manually from the Actions tab
workflow_dispatch:
branches: [ master ]

jobs:
# Contains a single job called "ci"
ci:
runs-on: ubuntu-latest
steps:
# Checks out repository under $GITHUB_WORKSPACE, so job can access it
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Install flake8
run: sudo apt install flake8
- name: Give executable permissions to the script
run: pip install flake8
- name: Give executable permissions to run_ci.sh inside the scripts directory
run: chmod a+x scripts/run_ci.sh
- name: Run the ci script in scripts folder
- name: Run the ci script inside the scripts folder
run: sh scripts/run_ci.sh
shell: bash
shell: bash
2 changes: 1 addition & 1 deletion coding/python/binary_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def binary_search(arr: List[int], lb: int, ub: int, target: int) -> int:
A Binary Search Example which has O(log n) time complexity.
"""
if lb <= ub:
mid: int = lb + (ub -lb)// 2
mid: int = lb + (ub - lb) // 2
if arr[mid] == target:
return mid
elif arr[mid] < target:
Expand Down

0 comments on commit 84640e8

Please sign in to comment.