Skip to content

Commit

Permalink
Don't treat all warnings as errors.
Browse files Browse the repository at this point in the history
On Illumos Google absl will generate a warning which will kill the build
if we treat warnings as errors.
  • Loading branch information
siepkes committed Jul 13, 2021
1 parent de76b31 commit 231008f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bazel/build_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ UPB_DEFAULT_CPPOPTS = select({
# copybara:strip_for_google3_begin
"-Wextra",
# "-Wshorten-64-to-32", # not in GCC (and my Kokoro images doesn't have Clang)
"-Werror",
#"-Werror", # Google absl gives a warning on Illumos. Breaks the build with warnings as errors.
"-Wno-long-long",
# copybara:strip_end
],
Expand Down

0 comments on commit 231008f

Please sign in to comment.