don't blow up on nil reports

sikachu · Oct 23, 2015 · 422090c · 422090c
1 parent 9b23382
commit 422090c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/lib/capistrano/fiesta/version.rb b/lib/capistrano/fiesta/version.rb
@@ -1,5 +1,5 @@
 module Capistrano
  module Fiesta
- VERSION = "1.0.0"
+ VERSION = "1.0.1"
  end
 end
diff --git a/lib/capistrano/tasks/fiesta.rake b/lib/capistrano/tasks/fiesta.rake
@@ -20,7 +20,7 @@ namespace :fiesta do
  report = Capistrano::Fiesta::Report.new(repo_url, last_release: fetch(:last_release))
  result = report.write
 
- if !result.empty?
+ if result && !result.empty?
  Slackistrano.post(
  team: fetch(:slack_team),
  token: fetch(:slack_token),

diff --git a/test/capistrano/fiesta/report_test.rb b/test/capistrano/fiesta/report_test.rb
@@ -16,6 +16,13 @@ def test_write
  end
  end
 
+ def test_no_new_stories
+ response = { items: [] }
+ github = stub_request(:get, /github.com/).to_return_json(response)
+ assert true, report.write.nil?
+ assert_requested github
+ end
+
  private
 
  def report