Skip to content

Commit

Permalink
firewire: core: remove obsolete comment
Browse files Browse the repository at this point in the history
Target-like applications or peer-to-peer-like applications require the
global address handler registration which we have right now, or a per-
card registration.  And node lookup, while it would be nice to have,
would be impossible in the brief time between self-ID-complete event and
completion of firewire-core's topology scanning.

Signed-off-by: Stefan Richter <[email protected]>
  • Loading branch information
Stefan Richter committed Feb 22, 2012
1 parent 26b4950 commit 280f64d
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/firewire/core-transaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -840,14 +840,6 @@ static void handle_exclusive_region_request(struct fw_card *card,
offset, request->length);
spin_unlock_irqrestore(&address_handler_lock, flags);

/*
* FIXME: lookup the fw_node corresponding to the sender of
* this request and pass that to the address handler instead
* of the node ID. We may also want to move the address
* allocations to fw_node so we only do this callback if the
* upper layers registered it for this node.
*/

if (handler == NULL)
fw_send_response(card, request, RCODE_ADDRESS_ERROR);
else
Expand Down

0 comments on commit 280f64d

Please sign in to comment.