Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds slim language support #11

Merged
merged 1 commit into from
Jan 1, 2016
Merged

Adds slim language support #11

merged 1 commit into from
Jan 1, 2016

Conversation

filipelinhares
Copy link
Contributor

No description provided.

@simurai
Copy link
Owner

simurai commented Jan 1, 2016

Thanks for your PR. Is it for https://atom.io/packages/language-slim or maybe https://atom.io/packages/slim-language?

I'm still unsure how many/which languages should be included.. see simurai/duotone-syntax#2. But as said in the comment, we can think about it later again.

simurai added a commit that referenced this pull request Jan 1, 2016
@simurai simurai merged commit e8a6cad into simurai:master Jan 1, 2016
@filipelinhares
Copy link
Contributor Author

This is for slim-language. I found one issue in each package:

The slim-language don't highlight attrs (the printscreen is after my modification) and don't highlight inline ruby:
image

and language-slim don't highlight attrs:
image

My PR cover the attrs for slim-language package

@simurai
Copy link
Owner

simurai commented Jan 4, 2016

Is it possible to fix it in both language packages without messing each other up?

Or maybe it's better to fix it in the actual language package itself and not each theme.

@filipelinhares
Copy link
Contributor Author

To remove the slim.less file we can replace .html.attribute-name with just .attribute-name.

I don't know exactly how language package works, but the problem is the parser isn't adding the right classes.
Maybe this line could be the point to solve the language-slim problem with attributes.

@simurai
Copy link
Owner

simurai commented Jan 4, 2016

To remove the slim.less file we can replace .html.attribute-name with just .attribute-name.

That might be a good idea. Actually, in _base.less, there shouldn't be any language specific selectors anyways.

Maybe this line could be the point to solve the language-slim problem with attributes.

Ya, currently "language-slim" adds entity name tag slim to attributes. A more specific attribute-name would help. Feel free to open an issue there.

simurai added a commit to simurai/duotone-syntax that referenced this pull request Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants