deprecate kvstoreclientinternal

Summary: as title this is not being used except in test. In test, we were using a subscribe model where we trigger callback once the update completes. In order to remove dependency on this. We simply use a synchronous method(it's a test anyway) to read from queue and directly call the callback once there is an update Reviewed By: xiangxu1121 Differential Revision: D42623870 fbshipit-source-id: 2ac3cf0e38bc284220e5843351afa4b686625610
simuthus-fb · Jan 23, 2023 · dd4f56f · dd4f56f
1 parent a6fba7c
commit dd4f56f
Show file tree

Hide file tree

Showing 9 changed files with 165 additions and 2,040 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -236,7 +236,6 @@ add_library(openrlib
   openr/dispatcher/DispatcherQueue.cpp
   openr/kvstore/Dual.cpp
   openr/fib/Fib.cpp
-  openr/kvstore/KvStoreClientInternal.cpp
   openr/kvstore/KvStorePublisher.cpp
   openr/kvstore/KvStoreUtil.cpp
   openr/kvstore/KvStoreWrapper.cpp
@@ -606,12 +605,6 @@ if(BUILD_TESTS)
     DESTINATION sbin/tests/openr/kvstore
   )
 
-  add_openr_test(KvStoreClientInternalTest kvstore_client_internal_test
-    SOURCES
-      openr/kvstore/tests/KvStoreClientInternalTest.cpp
-    DESTINATION sbin/tests/openr/kvstore
-  )
-
   add_openr_test(KvStoreUtilTest kvstore_util_test
     SOURCES
       openr/kvstore/tests/KvStoreUtilTest.cpp

diff --git a/examples/KvStoreAgent.cpp b/examples/KvStoreAgent.cpp
diff --git a/examples/KvStoreAgent.h b/examples/KvStoreAgent.h