[clj-kondo#950] Fix resolving class names

sittim · Aug 6, 2020 · de925fa · de925fa
1 parent 365ac5f
commit de925fa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/clj_kondo/impl/namespace.clj b/src/clj_kondo/impl/namespace.clj
@@ -246,10 +246,11 @@
            (update ns :imports merge imports)))
   nil)
 
-(defn class-name? [s]
-  (let [splits (str/split s #"\.")]
-    (and (> (count splits) 2)
-         (Character/isUpperCase ^char (first (last splits))))))
+(defn class-name? [^String s]
+  (when-let [i (str/last-index-of s \.)]
+    (let [should-be-capital-letter-idx (inc i)]
+      (and (> (.length s) should-be-capital-letter-idx)
+           (Character/isUpperCase ^char (.charAt s (inc i)))))))
 
 (defn reg-unresolved-symbol!
   [{:keys [:namespaces] :as _ctx}

diff --git a/test/clj_kondo/main_test.clj b/test/clj_kondo/main_test.clj
@@ -1751,7 +1751,8 @@ foo/foo ;; this does use the private var
                      {:linters {:type-mismatch {:level :error}}})))
   (is (empty? (lint! "(def x) (doto x)")))
   (is (empty? (lint! "(def ^:private a 1) (let [{:keys [a] :or {a a}} {}] a)"
-                     {:linters {:unused-binding {:level :warning}}}))))
+                     {:linters {:unused-binding {:level :warning}}})))
+  (is (empty? (lint! "(scala.Int/MinValue)" {:linters {:unresolved-symbol {:level :error}}}))))
 
 (deftest proxy-super-test
   (is (empty? (lint! "