forked from alpinejs/alpine
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request alpinejs#887 from HugoDF/feat-basic-error-handling
Feat: better (eval) error messages/context
- Loading branch information
Showing
4 changed files
with
177 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| import Alpine from 'alpinejs' | ||
| import { wait } from '@testing-library/dom' | ||
|
|
||
| global.MutationObserver = class { | ||
| observe() {} | ||
| } | ||
|
|
||
| jest.spyOn(window, 'setTimeout').mockImplementation((callback) => { | ||
| callback() | ||
| }) | ||
|
|
||
| const mockConsoleError = jest.spyOn(console, 'error').mockImplementation(() => {}) | ||
|
|
||
| beforeEach(() => { | ||
| jest.clearAllMocks() | ||
| }) | ||
|
|
||
| test('error in x-data eval contains element, expression and original error', async () => { | ||
| document.body.innerHTML = ` | ||
| <div x-data="{ foo: 'bar' "> | ||
| <span x-bind:foo="foo.bar"></span> | ||
| </div> | ||
| ` | ||
| await expect(Alpine.start()).rejects.toThrow() | ||
| expect(mockConsoleError).toHaveBeenCalledWith( | ||
| "Alpine: error in expression \"{ foo: 'bar' \" in component:", | ||
| document.querySelector('[x-data]'), | ||
| "due to \"SyntaxError: Unexpected token ')'\"" | ||
| ) | ||
| }) | ||
|
|
||
| test('error in x-init eval contains element, expression and original error', async () => { | ||
| document.body.innerHTML = ` | ||
| <div x-data x-init="foo.bar = 'baz'"> | ||
| </div> | ||
| ` | ||
| await Alpine.start() | ||
| expect(mockConsoleError).toHaveBeenCalledWith( | ||
| "Alpine: error in expression \"foo.bar = 'baz'\" in component:", | ||
| document.querySelector('[x-data]'), | ||
| "due to \"ReferenceError: foo is not defined\"" | ||
| ) | ||
| }) | ||
|
|
||
| test('error in x-spread eval contains element, expression and original error', async () => { | ||
| document.body.innerHTML = ` | ||
| <div x-data x-spread="foo.bar"> | ||
| </div> | ||
| ` | ||
| // swallow the rendering error | ||
| await expect(Alpine.start()).rejects.toThrow() | ||
| expect(mockConsoleError).toHaveBeenCalledWith( | ||
| "Alpine: error in expression \"foo.bar\" in component:", | ||
| document.querySelector('[x-data]'), | ||
| "due to \"ReferenceError: foo is not defined\"" | ||
| ) | ||
| }) | ||
|
|
||
| test('error in x-bind eval contains element, expression and original error', async () => { | ||
| document.body.innerHTML = ` | ||
| <div x-data="{ foo: null }"> | ||
| <span x-bind:foo="foo.bar"></span> | ||
| </div> | ||
| ` | ||
| await Alpine.start() | ||
| expect(mockConsoleError).toHaveBeenCalledWith( | ||
| "Alpine: error in expression \"foo.bar\" in component:", | ||
| document.querySelector('[x-bind:foo]'), | ||
| "due to \"TypeError: Cannot read property 'bar' of null\"" | ||
| ) | ||
| }) | ||
|
|
||
| test('error in x-model eval contains element, expression and original error', async () => { | ||
| document.body.innerHTML = ` | ||
| <div x-data="{ foo: null }"> | ||
| <input x-model="foo.bar"> | ||
| </div> | ||
| ` | ||
| await Alpine.start() | ||
| expect(mockConsoleError).toHaveBeenCalledWith( | ||
| "Alpine: error in expression \"foo.bar\" in component:", | ||
| document.querySelector('[x-model]'), | ||
| "due to \"TypeError: Cannot read property 'bar' of null\"" | ||
| ) | ||
| }) | ||
|
|
||
| test('error in x-for eval contains element, expression and original error', async () => { | ||
| document.body.innerHTML = ` | ||
| <div x-data="{}"> | ||
| <template x-for="element in foo"> | ||
| <span x-text="element"></span> | ||
| </template> | ||
| </div> | ||
| ` | ||
| await expect(Alpine.start()).rejects.toThrow() | ||
| expect(mockConsoleError).toHaveBeenCalledWith( | ||
| "Alpine: error in expression \"foo\" in component:", | ||
| document.querySelector('[x-for]'), | ||
| "due to \"ReferenceError: foo is not defined\"" | ||
| ) | ||
| }) | ||
|
|
||
| test('error in x-on eval contains element, expression and original error', async () => { | ||
| document.body.innerHTML = ` | ||
| <div | ||
| x-data="{hello: null}" | ||
| x-on:click="hello.world" | ||
| ></div> | ||
| ` | ||
| await Alpine.start() | ||
| document.querySelector('div').click() | ||
| await wait(() => { | ||
| expect(mockConsoleError).toHaveBeenCalledWith( | ||
| "Alpine: error in expression \"hello.world\" in component:", | ||
| document.querySelector('[x-data]'), | ||
| "due to \"TypeError: Cannot read property 'world' of null\"" | ||
| ) | ||
| }) | ||
| }) |