Always use textContent instead of innerText

sjfkai · Aug 29, 2020 · f70a71e · f70a71e
1 parent 3553835
commit f70a71e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/directives/text.js b/src/directives/text.js
@@ -4,9 +4,5 @@ export function handleTextDirective(el, output, expression) {
         output = ''
     }
 
-    if (el instanceof HTMLElement) {
-        el.innerText = output
-    } else {
-        el.textContent = output
-    }
+    el.textContent = output
 }
diff --git a/test/text.spec.js b/test/text.spec.js
@@ -14,7 +14,7 @@ test('x-text on init', async () => {
 
     Alpine.start()
 
-    await wait(() => { expect(document.querySelector('span').innerText).toEqual('bar') })
+    await wait(() => { expect(document.querySelector('span').textContent).toEqual('bar') })
 })
 
 test('x-text on triggered update', async () => {
@@ -28,11 +28,11 @@ test('x-text on triggered update', async () => {
 
     Alpine.start()
 
-    await wait(() => { expect(document.querySelector('span').innerText).toEqual('') })
+    await wait(() => { expect(document.querySelector('span').textContent).toEqual('') })
 
     document.querySelector('button').click()
 
-    await wait(() => { expect(document.querySelector('span').innerText).toEqual('bar') })
+    await wait(() => { expect(document.querySelector('span').textContent).toEqual('bar') })
 })
 
 test('x-text on SVG elements', async () => {