chore: enable easier electron builds by hosting some packages (micros…

…oft#4383)

* decompose shell and api into smaller types

* nest plugin pages under bot scope

* simplify webpack config

* make extension client external

* add mechanism to sync client shell to iframe plugin host

* only fetch extensions when app mounts

* add plugin pages selector

* output source maps with extension bundles

* rename file

* clean up manifest after loading extensions

* add project api hook

* update sample plugin to use project api

* disable sample-ui-plugin

* do not sync store to window

* prepare test-utils and types for publishing

* update package references to published pacakges

* add types package

* remove shared dependency from extension-client

* remove data from shell

* more types updates

* add useFormHook to expose current form data

* re-order useEffects

* add missing import

* move types to dependencies

* fix type errors

* add missing dependency

* fix tests

* remove old comments

* update lockfile

* use stub currentDialog when none found

* fix build:dev

* fix merge conflict

* add @botframework-composer/types to client

.vscode/snippets.json.code-snippets

@@ -1,26 +1,26 @@
 {
-	// Place your BotFramework-Composer workspace snippets here. Each snippet is defined under a snippet name and has a scope, prefix, body and
-	// description. Add comma separated ids of the languages where the snippet is applicable in the scope field. If scope
-	// is left empty or omitted, the snippet gets applied to all languages. The prefix is what is
-	// used to trigger the snippet and the body will be expanded and inserted. Possible variables are:
-	// $1, $2 for tab stops, $0 for the final cursor position, and ${1:label}, ${2:another} for placeholders.
-	// Placeholders with the same ids are connected.
-	"React component test scaffolding": {
-		"prefix": "rct",
-		"body": [
-			"import React from 'react';",
-      "import { render } from '@bfc/test-utils';",
+  // Place your BotFramework-Composer workspace snippets here. Each snippet is defined under a snippet name and has a scope, prefix, body and
+  // description. Add comma separated ids of the languages where the snippet is applicable in the scope field. If scope
+  // is left empty or omitted, the snippet gets applied to all languages. The prefix is what is
+  // used to trigger the snippet and the body will be expanded and inserted. Possible variables are:
+  // $1, $2 for tab stops, $0 for the final cursor position, and ${1:label}, ${2:another} for placeholders.
+  // Placeholders with the same ids are connected.
+  "React component test scaffolding": {
+    "prefix": "rct",
+    "body": [
+      "import React from 'react';",
+      "import { render } from '@botframework-composer/test-utils';",
       "import assign from 'lodash/assign';\n",
       "import { $1 } from '$2';\n",
       "const defaultProps = {\n  $3\n};\n",
       "function renderSubject(overrides = {}) {",
       "  const props = assign({}, defaultProps, overrides);",
       "  return render(<$1 {...props} />);",
       "}\n",
-			"describe('<$1 />', () => {",
-			"  it.todo('$0');",
-			"});\n"
-		],
-		"description": "React component test scaffolding"
-	}
+      "describe('<$1 />', () => {",
+      "  it.todo('$0');",
+      "});\n"
+    ],
+    "description": "React component test scaffolding"
+  }
 }

Composer/.npmrc

@@ -1,2 +1 @@
-@bfcomposer:registry=https://botbuilder.myget.org/F/botbuilder-declarative/npm/
 scripts-prepend-node-path=true

Composer/package.json

@@ -38,11 +38,11 @@
   "scripts": {
     "build": "node scripts/begin.js && yarn build:prod && yarn l10n",
     "build:prod": "yarn build:dev && yarn build:client && yarn build:server && yarn build:electron",
-    "build:dev": "wsrun -ltm -x @bfc/electron-server -x @bfc/client -x @bfc/server -p @bfc/* -c build && yarn build:plugins",
+    "build:dev": "wsrun -ltm -x @bfc/electron-server -x @bfc/client -x @bfc/server -p @botframework-composer/* -p @bfc/* -c build && yarn build:plugins",
     "build:electron": "yarn workspace @bfc/electron-server build && yarn workspace @bfc/electron-server l10n",
     "build:server": "yarn workspace @bfc/server build",
     "build:client": "yarn workspace @bfc/client build",
-    "build:plugins": "yarn build:plugins:localpublish && yarn build:plugins:samples && yarn build:plugins:azurePublish && yarn build:plugins:runtimes & yarn build:plugins:vacore",
+    "build:plugins": "yarn build:plugins:localpublish && yarn build:plugins:samples && yarn build:plugins:azurePublish && yarn build:plugins:runtimes && yarn build:plugins:vacore",
     "build:plugins:localpublish": "cd plugins/localPublish && yarn install && yarn build",
     "build:plugins:samples": "cd plugins/samples && yarn install && yarn build",
     "build:plugins:azurePublish": "cd plugins/azurePublish && yarn install && yarn build",

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/AdaptiveFlowEditor.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 import { EditorExtensionContext } from '@bfc/extension-client';
 
 import AdaptiveFlowEditor from '../../src/adaptive-flow-editor/AdaptiveFlowEditor';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/components/IconMenu.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render, fireEvent, findByText } from '@bfc/test-utils';
+import { render, fireEvent, findByText } from '@botframework-composer/test-utils';
 
 import { IconMenu } from '../../../src/adaptive-flow-editor/components/IconMenu';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/components/KeyboardZone.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render, fireEvent } from '@bfc/test-utils';
+import { render, fireEvent } from '@botframework-composer/test-utils';
 
 import { enableKeyboardCommandAttributes } from '../../../src/adaptive-flow-editor/components/KeyboardZone';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/contexts/NodeRendererContext.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React, { useContext } from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 import { DialogFactory } from '@bfc/shared';
 
 import { NodeRendererContext } from '../../../src/adaptive-flow-editor/contexts/NodeRendererContext';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/contexts/SelectionContext.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React, { useContext } from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { SelectionContext } from '../../../src/adaptive-flow-editor/contexts/SelectionContext';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/hooks/useEditorEventApi.test.ts

@@ -1,15 +1,15 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-import { renderHook } from '@bfc/test-utils/lib/hooks';
+import { renderHook } from '@botframework-composer/test-utils/lib/hooks';
 
 import { useEditorEventApi } from '../../../src/adaptive-flow-editor/hooks/useEditorEventApi';
 import { ShellApiStub } from '../stubs/ShellApiStub';
 import { defaultRendererContextValue } from '../../../src/adaptive-flow-editor/contexts/NodeRendererContext';
 import { defaultSelectionContextValue } from '../../../src/adaptive-flow-editor/contexts/SelectionContext';
 import { NodeEventTypes } from '../../../src/adaptive-flow-renderer/constants/NodeEventTypes';
 
-describe('useSelectionEffect', () => {
+describe('useEditorEventApi', () => {
   const hook = renderHook(() =>
     useEditorEventApi(
       {

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/renderers/EdgeMenu.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 import { DialogGroup } from '@bfc/shared';
 
 import { EdgeMenu } from '../../../src/adaptive-flow-editor/renderers/EdgeMenu';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/renderers/ElementWrapper.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { ElementWrapper } from '../../../src/adaptive-flow-editor/renderers/ElementWrapper';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/renderers/NodeMenu.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render, fireEvent, findAllByText } from '@bfc/test-utils';
+import { render, fireEvent, findAllByText } from '@botframework-composer/test-utils';
 
 import { NodeMenu } from '../../../src/adaptive-flow-editor/renderers/NodeMenu';
 import { NodeEventTypes } from '../../../src/adaptive-flow-renderer/constants/NodeEventTypes';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/renderers/NodeWrapper.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render, fireEvent } from '@bfc/test-utils';
+import { render, fireEvent } from '@botframework-composer/test-utils';
 import { EditorExtensionContext } from '@bfc/extension-client';
 
 import { ActionNodeWrapper } from '../../../src/adaptive-flow-editor/renderers/NodeWrapper';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-editor/stubs/ShellApiStub.ts

@@ -21,11 +21,16 @@ export const ShellApiStub: ShellApi = {
   updateLgTemplate: fnPromise,
   removeLgTemplate: fnPromise,
   removeLgTemplates: fnPromise,
+  updateLgFile: fnPromise,
+  debouncedUpdateLgTemplate: fnPromise,
   getLuIntent: fn,
   getLuIntents: fnList,
   addLuIntent: fnPromise,
   updateLuIntent: fnPromise,
   removeLuIntent: fn,
+  updateLuFile: fnPromise,
+  debouncedUpdateLuIntent: fnPromise,
+  renameLuIntent: fnPromise,
   updateRegExIntent: fn,
   createDialog: fnPromise,
   addCoachMarkRef: fn,
@@ -36,6 +41,21 @@ export const ShellApiStub: ShellApi = {
   addSkillDialog: fnPromise,
   announce: fn,
   displayManifestModal: fn,
+  constructAction: fnPromise,
+  constructActions: fnPromise,
+  copyAction: fnPromise,
+  copyActions: fnPromise,
+  deleteAction: fnPromise,
+  deleteActions: fnPromise,
+  actionsContainLuIntent: fn,
+  updateQnaContent: fnPromise,
+  renameRegExIntent: fnPromise,
+  updateIntentTrigger: fnPromise,
+  commitChanges: fnPromise,
+  updateDialogSchema: fnPromise,
+  createTrigger: fnPromise,
+  updateSkillSetting: fnPromise,
+  updateFlowZoomRate: fnPromise,
 };
 
 describe('ShellApiStub', () => {

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/adaptive/AdaptiveDialog.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { AdaptiveKinds } from '../../../src/adaptive-flow-renderer/constants/AdaptiveKinds';
 import { AdaptiveDialog } from '../../../src/adaptive-flow-renderer/adaptive/AdaptiveDialog';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/adaptive/AdaptiveTrigger.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { AdaptiveTrigger } from '../../../src/adaptive-flow-renderer/adaptive/AdaptiveTrigger';
 import { SchemaContext } from '../../../src/adaptive-flow-renderer/contexts/SchemaContext';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/components/ArrowLine.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { ArrowLine } from '../../../src/adaptive-flow-renderer/components/ArrowLine';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/components/Diamond.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { Diamond } from '../../../src/adaptive-flow-renderer/components/Diamond';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/components/ElementMeasurer.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { ElementMeasurer } from '../../../src/adaptive-flow-renderer/components/ElementMeasurer';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/components/FlowEdges.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { FlowEdges } from '../../../src/adaptive-flow-renderer/components/FlowEdges';
 import { Edge } from '../../../src/adaptive-flow-renderer/models/EdgeData';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/components/IconBrick.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { IconBrick } from '../../../src/adaptive-flow-renderer/components/IconBrick';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/components/LoopIndicator.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { LoopIndicator } from '../../../src/adaptive-flow-renderer/components/LoopIndicator';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/components/OffsetContainer.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { OffsetContainer } from '../../../src/adaptive-flow-renderer/components/OffsetContainer';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/components/SVGContainer.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { SVGContainer } from '../../../src/adaptive-flow-renderer/components/SVGContainer';
 

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/utils/EdgeUtil.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { drawSVGEdge } from '../../../src/adaptive-flow-renderer/utils/visual/EdgeUtil';
 import { EdgeDirection } from '../../../src/adaptive-flow-renderer/models/EdgeData';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/utils/widgetRenderer.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 import { WidgetComponent, FlowEditorWidgetMap, FlowWidget } from '@bfc/extension-client';
 
 import { renderUIWidget, UIWidgetContext } from '../../../src/adaptive-flow-renderer/utils/visual/widgetRenderer';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/widgets/ActionCard.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { ActionCard } from '../../../src/adaptive-flow-renderer/widgets';
 import { AdaptiveKinds } from '../../../src/adaptive-flow-renderer/constants/AdaptiveKinds';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/widgets/DialogRef.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { DialogRef } from '../../../src/adaptive-flow-renderer/widgets';
 import { AdaptiveKinds } from '../../../src/adaptive-flow-renderer/constants/AdaptiveKinds';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/widgets/ForeachWidget.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { ForeachWidget } from '../../../src/adaptive-flow-renderer/widgets';
 import { AdaptiveKinds } from '../../../src/adaptive-flow-renderer/constants/AdaptiveKinds';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/widgets/IfConditionWidget.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { IfConditionWidget } from '../../../src/adaptive-flow-renderer/widgets';
 import { AdaptiveKinds } from '../../../src/adaptive-flow-renderer/constants/AdaptiveKinds';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/widgets/PromptWidget.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { PromptWidget } from '../../../src/adaptive-flow-renderer/widgets';
 import { AdaptiveKinds } from '../../../src/adaptive-flow-renderer/constants/AdaptiveKinds';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/widgets/SwitchConditionWidget.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { SwitchConditionWidget } from '../../../src/adaptive-flow-renderer/widgets';
 import { AdaptiveKinds } from '../../../src/adaptive-flow-renderer/constants/AdaptiveKinds';

Composer/packages/adaptive-flow/__tests__/adaptive-flow-renderer/widgets/icon.test.tsx

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import React from 'react';
-import { render } from '@bfc/test-utils';
+import { render } from '@botframework-composer/test-utils';
 
 import { Icon } from '../../../src/adaptive-flow-renderer/widgets/ActionHeader/icon';
 

Composer/packages/adaptive-flow/jest.config.js

@@ -1,3 +1,3 @@
-const { createConfig } = require('@bfc/test-utils');
+const { createConfig } = require('@botframework-composer/test-utils');
 
 module.exports = createConfig('adaptive-form', 'react');

Composer/packages/adaptive-flow/package.json

@@ -45,7 +45,7 @@
     "react": "16.13.1"
   },
   "devDependencies": {
-    "@bfc/test-utils": "*",
+    "@botframework-composer/test-utils": "*",
     "@types/lodash": "^4.14.146",
     "@types/react": "16.9.23",
     "format-message": "^6.2.3",