Skip to content

Commit

Permalink
lint: Remove old jslint linter.
Browse files Browse the repository at this point in the history
Now that we're using eslint, jslint is no longer required.
  • Loading branch information
kevv87 authored and timabbott committed Dec 3, 2016
1 parent 2c940b9 commit 1fb9220
Show file tree
Hide file tree
Showing 10 changed files with 7 additions and 6,656 deletions.
1 change: 0 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
static/js/bundle.js
static/js/blueslip.js
puppet/zulip_ops/files/statsd/local.js
tools/jslint/check-all.js
4 changes: 0 additions & 4 deletions docs/THIRDPARTY
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,6 @@ Files: tools/inject-messages/othello
Copyright: Shakespeare
License: public-domain

Files: tools/jslint/jslint.js
Copyright: 2002 Douglas Crockford
License: XXX-good-not-evil

Files: tools/review
Copyright: 2010 Ksplice, Inc.
License: Apache-2.0
Expand Down
7 changes: 1 addition & 6 deletions docs/code-style.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,7 @@ The Vagrant setup process runs this for you.

`lint-all` runs many lint checks in parallel, including

- JavaScript ([JSLint](http://www.jslint.com/))

> `tools/jslint/check-all.js` contains a pretty fine-grained set of
> JSLint options, rule exceptions, and allowed global variables. If
> you add a new global, you'll need to add it to the list.
- JavaScript ([ESLint](http://eslint.org/))
- Python ([Pyflakes](http://pypi.python.org/pypi/pyflakes))
- templates
- Puppet configuration
Expand Down
11 changes: 6 additions & 5 deletions docs/linters.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ prevent common coding errors.
We borrow some open source tools for much of our linting, and the links
below will direct you to the official documentation for these projects.

- [jslint](https://github.com/douglascrockford/JSLint)
- [eslint](http://eslint.org)
- [mypy](http://mypy-lang.org/)
- [puppet](https://puppet.com/) (puppet provides its own mechanism for validating manifests)
- [puppet](https://puppet.com/) (puppet provides its own mechanism for
validating manifests)
- [pyflakes](https://pypi.python.org/pypi/pyflakes)

Zulip also uses some home-grown code to perform tasks like validating
Expand Down Expand Up @@ -81,7 +82,7 @@ Most of our lint checks get performed by `./tools/lint-all`. These include the
following checks:

- Check Python code with pyflakes.
- Check JavaScript code with jslint.
- Check JavaScript code with eslint.
- Check Python code for custom Zulip rules.
- Check non-Python code for custom Zulip rules.
- Check puppet manifests with the puppet validator.
Expand All @@ -102,7 +103,7 @@ The rest of this document pertains to the checks that occur in `./tools/lint-all
Zulip has a script called `lint-all` that lives in our "tools" directory.
It is the workhorse of our linting system, although in some cases it
dispatches the heavy lifting to other components such as pyflakes,
jslint, and other home grown tools.
eslint, and other home grown tools.

You can find the source code [here](https://github.com/zulip/zulip/blob/master/tools/lint-all).

Expand Down Expand Up @@ -161,7 +162,7 @@ that we exempt may be deemed not worthwhile to fix.
#### JavaScript code

We check our JavaScript code in a few different ways:
- We run jslint.
- We run eslint.
- We perform custom Zulip regex checks on the code.
- We verify that all addClass calls, with a few exceptions, explicitly
contain a CSS class.
Expand Down
3 changes: 0 additions & 3 deletions static/js/debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@
The file may still be accessible under other circumstances, so do
not put sensitive information here. */

// It's fine to use console.log etc. in this file.
/*jslint devel: true */

/*
print_elapsed_time("foo", foo)
Expand Down
2 changes: 0 additions & 2 deletions static/js/message_list.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/*jslint nomen: true */
var message_list = (function () {

var exports = {};
Expand Down Expand Up @@ -642,7 +641,6 @@ $(document).on('message_selected.zulip zuliphashchange.zulip mousewheel', functi
return exports;

}());
/*jslint nomen: false */
if (typeof module !== 'undefined') {
module.exports = message_list;
}
166 changes: 0 additions & 166 deletions tools/jslint/check-all.js

This file was deleted.

Loading

0 comments on commit 1fb9220

Please sign in to comment.