Refactor/sky rev fwd #1830
Draft
Refactor/sky rev fwd #1830
+1,177
−740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
added 3 commits
June 17, 2024 12:07
Rename the `skyrev` package to `con` and `skyfwd` to `pub` under the `net` command. This change improves the clarity and consistency of the codebase.
ersonp
force-pushed
the
refactor/sky-rev-fwd
branch
from
526f486 to
8ee38fa
Compare
Add support for HTTP, TCP, UDP in the API, RPC and CMD
Ensure port availability before adding ConnectConn and PublishListener
Update `Connect` and `Publish` API to return ConnectInfo and PublishInfo as well as for `ListPublished` and `ListConnected` to return []PublishInfo and []ConnectInfo
Remove ReadHeaderTimeout and WriteTimeout that were causing the publisher to close the incoming connection if nothing was connectead to it withing 5 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check?Fixes #
Changes:
How to test this PR: