Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/databinding #9

Merged
merged 7 commits into from
Jun 7, 2019
Merged

Feature/databinding #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6860c39
updates gradle depdendency versions
skydoves Jun 7, 2019
4d09a5a
refactor & rearrange codes
skydoves Jun 7, 2019
b01db7b
implements FragmentExtension & intent objects
skydoves Jun 7, 2019
fcb35b9
modified gitignore
skydoves Jun 7, 2019
ee82281
implements fragments logics via databinding
skydoves Jun 7, 2019
e59013d
added license on the codes header
skydoves Jun 7, 2019
6a1b1af
modified unit tests
skydoves Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
updates gradle depdendency versions
  • Loading branch information
@skydoves
skydoves committed Jun 7, 2019
commit 6860c3965bf971605a66d57461db8c472daddab5
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
3 changes: 3 additions & 0 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ android {
kapt {
correctErrorTypes = true
}
dataBinding {
enabled = true
}
buildTypes {
release {
minifyEnabled false
Expand Down
8 changes: 4 additions & 4 deletions app/src/main/java/com/skydoves/themovies/view/ui/main/MainPagerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import androidx.fragment.app.FragmentPagerAdapter
class MainPagerAdapter(fm: FragmentManager) : FragmentPagerAdapter(fm) {

override fun getItem(position: Int): Fragment {
when (position) {
0 -> return MovieListFragment()
1 -> return TvListFragment()
else -> return PersonListFragment()
return when (position) {
0 -> MovieListFragment()
1 -> TvListFragment()
else -> PersonListFragment()
}
}

Expand Down
12 changes: 6 additions & 6 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ buildscript {

// application dependencies
androidxVersion = '1.0.0'
accompatVersion = '1.1.0-alpha05'
materialVersion = '1.1.0-alpha06'
accompatVersion = '1.1.0-beta01'
materialVersion = '1.1.0-alpha07'
recyclerVersion = '1.1.0-alpha05'
kotlinVersion = '1.3.21'
ankoVersion = '0.10.8'
archCompomentVersion = '2.0.0'
roomVersion = '2.1.0-beta01'
livedataKtx = '2.1.0-beta01'
daggerVersion = '2.22.1'
roomVersion = '2.1.0-rc01'
livedataKtx = '2.2.0-alpha01'
daggerVersion = '2.23.1'
retrofitVersion = '2.3.0'
okhttpVersion = '3.11.0'
gsonVersion = '2.8.2'
Expand Down Expand Up @@ -45,7 +45,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:3.4.0'
classpath "com.android.tools.build:gradle:3.4.1"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
classpath "com.diffplug.spotless:spotless-plugin-gradle:$spotlessVersion"
classpath "org.jacoco:org.jacoco.core:$jacocoVersion"
Expand Down