Skip to content

Commit

Permalink
[media] cx231xx: simplify I2C scan debug messages
Browse files Browse the repository at this point in the history
Don't need to show when it starts or stops. Just print lines
when devices are found.

After the changes, the output for i2c scan will be like:

	usb 1-2: i2c scan: found device @ port 0 addr 0x40  [???]
	usb 1-2: i2c scan: found device @ port 0 addr 0x60  [colibri]
	usb 1-2: i2c scan: found device @ port 0 addr 0x88  [hammerhead]
	usb 1-2: i2c scan: found device @ port 0 addr 0x98  [???]
	usb 1-2: i2c scan: found device @ port 3 addr 0xa0  [eeprom]
	usb 1-2: i2c scan: found device @ port 2 addr 0x60  [colibri]
	usb 1-2: i2c scan: found device @ port 2 addr 0xc0  [tuner]
	usb 1-2: i2c scan: found device @ port 4 addr 0x20  [demod]

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
mchehab committed Nov 3, 2014
1 parent 3d28cf3 commit ac550fa
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/media/usb/cx231xx/cx231xx-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -502,21 +502,17 @@ void cx231xx_do_i2c_scan(struct cx231xx *dev, int i2c_port)
memset(&client, 0, sizeof(client));
client.adapter = cx231xx_get_i2c_adap(dev, i2c_port);

dev_info(&dev->udev->dev,
"i2c_scan: checking for I2C devices on port=%d ..\n",
i2c_port);
for (i = 0; i < 128; i++) {
client.addr = i;
rc = i2c_master_recv(&client, &buf, 0);
if (rc < 0)
continue;
dev_info(&dev->udev->dev,
"i2c scan: found device @ 0x%x [%s]\n",
"i2c scan: found device @ port %d addr 0x%x [%s]\n",
i2c_port,
i << 1,
i2c_devs[i] ? i2c_devs[i] : "???");
}
dev_info(&dev->udev->dev, "i2c scan: Completed Checking for I2C devices on port=%d.\n",
i2c_port);

dev->i2c_scan_running = false;
}
Expand Down

0 comments on commit ac550fa

Please sign in to comment.