Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Prometheus recording rule format #11

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Conversation

slok
Copy link
Owner

@slok slok commented Apr 18, 2021

No description provided.

Signed-off-by: Xabier Larrakoetxea <[email protected]>
@slok
Copy link
Owner Author

slok commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@fb8eef8). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage        ?   89.53%           
=======================================
  Files           ?        5           
  Lines           ?      172           
  Branches        ?        0           
=======================================
  Hits            ?      154           
  Misses          ?        9           
  Partials        ?        9           
Impacted Files Coverage Δ
internal/prometheus/recording_rules.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb8eef8...e7eebe6. Read the comment docs.

@slok slok merged commit ee2e2b1 into main Apr 18, 2021
@slok slok deleted the slok/improve-linting branch April 18, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant