fix abs

sm2x · Mar 11, 2020 · fb69e12 · fb69e12
1 parent 7ebee2b
commit fb69e12
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/Simple/BCMath.php b/src/Simple/BCMath.php
@@ -111,11 +111,17 @@ public function round($number, int $precision = 0): string
      */
     public function abs($number): string
     {
-        if ($this->isNegative($number)) {
-            return substr($number, 1);
-        }
+        try {
+            $this->add($number, 0); // validator
+            if ($this->isNegative($number)) {
+                return substr($number, 1);
+            }
 
-        return $number;
+            return $number;
+        } catch (\Throwable $throwable) {
+            // this is not a number
+            return 0;
+        }
     }
 
     /**

diff --git a/tests/MathTest.php b/tests/MathTest.php
@@ -21,6 +21,11 @@ public function testAbs(string $class): void
          */
         $provider = app($class);
 
+        // not number
+        $this->assertEquals($provider->abs('hello'), 0);
+        $this->assertEquals($provider->abs('--121'), 0);
+        $this->assertEquals($provider->abs('---121'), 0);
+
         // int
         $this->assertEquals($provider->abs(123), 123);
         $this->assertEquals($provider->abs(-123), 123);