This repository has been archived by the owner on Nov 7, 2020. It is now read-only.
Fixes issue #16 #17
Open
Fixes issue #16 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Break down Timer.current_time into two fields:
* Timer.start_timestamp
* Timer.paused_offset
Combining those two with a reference timestamp (usually 'now'), it is
possible to calculate the ellapsed time. The benefits are: that we don't have
to rely on the app_timer_register callback; Timers are able to be restored
to the correct time, after being backgrounded, or even if the Pebble
Smartwatch has been powered off in between launches; It leaves the task of
tracking the passage of time up to Pebble itself, where it excels.
The downside is that the timestamp depends on the local time, since there
is currently no API to use another time. Because of that, the timers will
be affected by changing timezones or when entering or leaving DST. In order
to avoid this, we need to use a time source that is increasing and monotonic.
* Get rid of app_timer_register.
* Use TickTimerService firing at each SECOND_UNIT to update the timers.
NOTE: This commit changes the timer data structure, but leaves migration. This
is going to be fixed soon.
This commit adds code to properly migrate data to the new storage version.
We should only account for offset if the timer was running.
|
This looks great! I'm going to review this as soon as I get a chance. Thanks for doing this. |
|
I'm glad to be able to help improve this app. |
See issue smallstoneapps#18, for details.
* Dealing with the update_marked flag only in timers_fire_update_handlers and timers_mark_update. * Fix derp on timers_update_timestamp, which would only disable queueing if something had been actually queued. It should always disable.
This field is useless, as of current timer implementation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the way timers keep track of time, preventing interference caused by intrinsic delays on app launch, background, persist tasks, system timer scheduling, etc.