-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce a flag to turn off SSRF protection for local development #16622
base: develop
Are you sure you want to change the base?
Conversation
jinhoonbang
commented
Feb 27, 2025
- Introduce a flag to turn off SSRF protection. This helps with local development when the gateway needs to make outgoing calls to localhost servers or docker containers.
- SSRF protection is enabled by default.
@jinhoonbang Can you use the AllowedIPs setting instead for this? That basically achieves whan you want |
@cedric-cordenier Is
I see some workarounds like this. But found this new flag to be simpler |
AER Report: CI Coreaer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Core Tests (go_core_tests) , GolangCI Lint (.) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , test-scripts , Core Tests (go_core_race_tests) , lint , SonarQube Scan 1. GolangCI Lint job failed:
|
var _ job.Delegate = (*Delegate)(nil) | ||
|
||
func NewDelegate(legacyChains legacyevm.LegacyChainContainer, ks keystore.Eth, ds sqlutil.DataSource, lggr logger.Logger) *Delegate { | ||
func NewDelegate(config Config, legacyChains legacyevm.LegacyChainContainer, ks keystore.Eth, ds sqlutil.DataSource, lggr logger.Logger) *Delegate { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will other fields from the config need to be accessed eventually? If not, does it make more sense to add a single boolean param to the constructor here instead? And maybe further along the param list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@jinhoonbang curious: can't the same be achieved by passing a list of allowed IPs to the gateway job? This is what I am doing in my e2e tests to allow nodes to access resources from the host machine. Here's the code: |
yes. we had to add this to gateway job specs to get things working. : |