-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sort providers #417
Conversation
@smeijer Sorry, accidentally canceled the pr while updating the branch name :/ |
fix: Fixed according to eslint rules.
@ramazansancar , all good. There are some merge conflicts now though. Do you have a sec to get those resolved? |
@smeijer I was just about to fix it. |
Thanks. Appreciated! |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
There were some problems with AMap. I fixed them. |
Head branch was pushed to by a user without write access
It was forgotten on the docs page. I added it there lastly. |
Sorry for the hassle and repetition. I just wanted it to be perfect. |
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Can you add me to your contributors? Thanks @smeijer |
@all-contributors please add ramazansancar for code |
I've put up a pull request to add @ramazansancar! 🎉 |
Adds @ramazansancar as a contributor for code. This was requested by smeijer [in this comment](#417 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sure thing! I've also added you as a collaborator on the project. Please continue to make PRs as you feel the need. You can now make your branches directly on the repo rather than your fork if you want. Thanks for your contributions! Much appreciated. |
Thanks for your offer. I think it would be healthy to evaluate the improvements via Issue or Discussion and move the process forward. Still, I would like someone to look at it as a second eye. Thanks again. |
fix: Fixed according to eslint rules.
I created another PR, separating the other improvements that remained in the previous PR.
Love from Turkey ❤