Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort providers #417

Merged
merged 9 commits into from
Jan 21, 2025
Merged

chore: sort providers #417

merged 9 commits into from
Jan 21, 2025

Conversation

ramazansancar
Copy link
Collaborator

fix: Fixed according to eslint rules.

I created another PR, separating the other improvements that remained in the previous PR.

Love from Turkey ❤

@ramazansancar
Copy link
Collaborator Author

@smeijer Sorry, accidentally canceled the pr while updating the branch name :/

fix: Fixed according to eslint rules.
@smeijer smeijer changed the title upd: Sort provider list. A-Z chore: sort providers Jan 21, 2025
@smeijer
Copy link
Owner

smeijer commented Jan 21, 2025

@ramazansancar , all good. There are some merge conflicts now though. Do you have a sec to get those resolved?

@ramazansancar
Copy link
Collaborator Author

@smeijer I was just about to fix it.

@smeijer smeijer enabled auto-merge (squash) January 21, 2025 19:32
@smeijer
Copy link
Owner

smeijer commented Jan 21, 2025

Thanks. Appreciated!

auto-merge was automatically disabled January 21, 2025 19:33

Head branch was pushed to by a user without write access

@smeijer smeijer enabled auto-merge (squash) January 21, 2025 19:36
auto-merge was automatically disabled January 21, 2025 19:37

Head branch was pushed to by a user without write access

@ramazansancar
Copy link
Collaborator Author

There were some problems with AMap. I fixed them.

@smeijer smeijer enabled auto-merge (squash) January 21, 2025 19:41
auto-merge was automatically disabled January 21, 2025 19:41

Head branch was pushed to by a user without write access

@ramazansancar
Copy link
Collaborator Author

It was forgotten on the docs page. I added it there lastly.

@smeijer smeijer enabled auto-merge (squash) January 21, 2025 19:42
@ramazansancar
Copy link
Collaborator Author

Sorry for the hassle and repetition. I just wanted it to be perfect.

docs/lib/providers.ts Outdated Show resolved Hide resolved
@smeijer smeijer merged commit 1e4ed3a into smeijer:main Jan 21, 2025
8 checks passed
@smeijer
Copy link
Owner

smeijer commented Jan 21, 2025

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ramazansancar
Copy link
Collaborator Author

Can you add me to your contributors? Thanks @smeijer

@smeijer
Copy link
Owner

smeijer commented Jan 21, 2025

@all-contributors please add ramazansancar for code

Copy link
Contributor

@smeijer

I've put up a pull request to add @ramazansancar! 🎉

smeijer pushed a commit that referenced this pull request Jan 21, 2025
Adds @ramazansancar as a contributor for code.

This was requested by smeijer [in this
comment](#417 (comment))

[skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@smeijer
Copy link
Owner

smeijer commented Jan 21, 2025

Sure thing!

I've also added you as a collaborator on the project. Please continue to make PRs as you feel the need. You can now make your branches directly on the repo rather than your fork if you want.

Thanks for your contributions! Much appreciated.

@ramazansancar
Copy link
Collaborator Author

Sure thing!

I've also added you as a collaborator on the project. Please continue to make PRs as you feel the need. You can now make your branches directly on the repo rather than your fork if you want.

Thanks for your contributions! Much appreciated.

Thanks for your offer. I think it would be healthy to evaluate the improvements via Issue or Discussion and move the process forward. Still, I would like someone to look at it as a second eye.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants