Skip to content

Commit

Permalink
Add extra perl packages to fix ddclient dependency
Browse files Browse the repository at this point in the history
Add the following packages:
- perl-Data-Validate-IP
- perl-NetAddr-IP

Also, now that these packages fix the missing runtime dependency
for ddclient, add the latter back to the full iso install package
list.

Change-Id: Iffd1dfd3e52c1f2f586b358f9155e3ad9c90f036
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/5821
Tested-by: gerrit-photon <[email protected]>
Reviewed-by: Anish Swaminathan <[email protected]>
  • Loading branch information
srivatsabhat authored and suezzelur committed Sep 28, 2018
1 parent f2dd2fb commit 08bb6f5
Show file tree
Hide file tree
Showing 4 changed files with 88 additions and 1 deletion.
5 changes: 4 additions & 1 deletion SPECS/ddclient/ddclient.spec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Name: ddclient
Version: 3.9.0
Release: 1%{?dist}
Release: 2%{?dist}
Url: https://sourceforge.net/p/ddclient/wiki/Home/
Summary: Perl client used to update dynamic DNS entries for accounts on Dynamic DNS Network Service Provider
License: GPLv2
Expand All @@ -11,6 +11,7 @@ Source0: http://downloads.sourceforge.net/project/ddclient/ddclient/ddcli
Requires: perl
Requires: perl-IO-Socket-SSL
Requires: perl-JSON-Any
Requires: perl-Data-Validate-IP

%description
DDclient is a Perl client used to update dynamic DNS entries for accounts on Dynamic DNS Network Service Provider. It was originally written by Paul Burry and is now mostly by wimpunk. It has the capability to update more than just dyndns and it can fetch your WAN-ipaddress in a few different ways.
Expand Down Expand Up @@ -52,6 +53,8 @@ EOF
%dir /var/cache/ddclient

%changelog
* Thu Sep 27 2018 Srivatsa S. Bhat <[email protected]> 3.9.0-2
- Add perl-Data-Validate-IP as a runtime dependency.
* Mon Sep 10 2018 Ajay Kaher <[email protected]> 3.9.0-1
- Upgraded to version 3.9.0
* Fri Oct 13 2017 Alexey Makhalov <[email protected]> 3.8.3-3
Expand Down
44 changes: 44 additions & 0 deletions SPECS/perl-Data-Validate-IP/perl-Data-Validate-IP.spec
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
Summary: IPv4 and IPv6 validation methods
Name: perl-Data-Validate-IP
Version: 0.27
Release: 1%{?dist}
License: GPL+ or Artistic
Group: Development/Libraries
URL: https://metacpan.org/release/Data-Validate-IP
Source0: https://cpan.metacpan.org/authors/id/D/DR/DROLSKY/Data-Validate-IP-%{version}.tar.gz
%define sha1 Data-Validate-IP=da24fd6404359e475f65d35cb4341db74c48f48a
Vendor: VMware, Inc.
Distribution: Photon
BuildArch: noarch
BuildRequires: perl
Requires: perl
Requires: perl-NetAddr-IP

%description
This module provides a number IP address validation subs that both
validate and untaint their input. This includes both basic validation
(is_ipv4() and is_ipv6()) and special cases like checking whether an
address belongs to a specific network or whether an address is public
or private (reserved).

%prep
%setup -q -n Data-Validate-IP-%{version}

%build
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 OPTIMIZE="%{optflags}"
make %{?_smp_mflags}

%install
make install DESTDIR=%{buildroot}
find %{buildroot} -name 'perllocal.pod' -delete

%check
make test

%files
%{perl_vendorlib}/*
%{_mandir}/man3/*

%changelog
* Thu Sep 27 2018 Srivatsa S. Bhat <[email protected]> 0.27-1
- Initial version.
39 changes: 39 additions & 0 deletions SPECS/perl-NetAddr-IP/perl-NetAddr-IP.spec
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
Summary: Manages IPv4 and IPv6 addresses and subnets
Name: perl-NetAddr-IP
Version: 4.079
Release: 1%{?dist}
License: GPLv2+ or Artistic
Group: Development/Libraries
URL: https://metacpan.org/release/NetAddr-IP
Source0: https://cpan.metacpan.org/authors/id/M/MI/MIKER/NetAddr-IP-%{version}.tar.gz
%define sha1 NetAddr-IP=41f0048dccf016077e65b93a681e40b4f6b28336
Vendor: VMware, Inc.
Distribution: Photon
BuildRequires: perl
Requires: perl

%description
This module provides an object-oriented abstraction on top of IP
addresses or IP subnets, that allows for easy manipulations.

%prep
%setup -q -n NetAddr-IP-%{version}

%build
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 OPTIMIZE="%{optflags}"
make %{?_smp_mflags}

%install
make install DESTDIR=%{buildroot}
find %{buildroot} -name 'perllocal.pod' -delete

%check
make test

%files
%{perl_vendorlib}/*
%{_mandir}/man3/*

%changelog
* Thu Sep 27 2018 Srivatsa S. Bhat <[email protected]> 4.079-1
- Initial version.
1 change: 1 addition & 0 deletions common/data/packages_full.json
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@
"cifs-utils",
"c-ares",
"dnsmasq",
"ddclient",
"netmgmt",
"motd"
]
Expand Down

0 comments on commit 08bb6f5

Please sign in to comment.