Skip to content

Commit

Permalink
[flutter_releases] Flutter Dev 2.3.0-12.1.pre Framework Cherrypicks (f…
Browse files Browse the repository at this point in the history
…lutter#82852)

* enable uwp embedding in dev
* add tests
  • Loading branch information
christopherfujino authored May 18, 2021
1 parent 0f03147 commit f9c8259
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
4 changes: 4 additions & 0 deletions packages/flutter_tools/lib/src/features.dart
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,10 @@ const Feature windowsUwpEmbedding = Feature(
available: true,
enabledByDefault: false,
),
dev: FeatureChannelSetting(
available: true,
enabledByDefault: false,
),
);

/// A [Feature] is a process for conditionally enabling tool features.
Expand Down
13 changes: 13 additions & 0 deletions packages/flutter_tools/test/general.shard/features_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,19 @@ void main() {
expect(featureFlags.isWindowsUwpEnabled, true);
});

testWithoutContext('Flutter Windows UWP desktop off by default on dev', () {
final FeatureFlags featureFlags = createFlags('dev');

expect(featureFlags.isWindowsUwpEnabled, false);
});

testWithoutContext('Flutter Windows UWP desktop enabled with config on dev', () {
final FeatureFlags featureFlags = createFlags('dev');
testConfig.setValue('enable-windows-uwp-desktop', true);

expect(featureFlags.isWindowsUwpEnabled, true);
});

testWithoutContext('Flutter Windows UWP desktop off by default on stable', () {
final FeatureFlags featureFlags = createFlags('stable');

Expand Down

0 comments on commit f9c8259

Please sign in to comment.