Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - Regrouping Hardware requested menu & requestable menu #11338

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

veenone
Copy link
Contributor

@veenone veenone commented Jun 17, 2022

Description

To improve the correlation on request management perspective, the requestable & asset requested menu is grouped together pertaining the original access condition for both.

By grouping them in a group called Request Manager, the activity of requesting & handling request will be in the same place and IMO will be less confusing

Fixes #11334

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test A : test the new layout & the functionalities
  • Test B : test the layout with different user role

Test Configuration:

  • PHP version: 7.4.27
  • MySQL version
  • Webserver version
  • OS version: Windows 10

Checklist:

Screenshots

Before

image
image

After

image
image

@veenone veenone requested a review from snipe as a code owner June 17, 2022 17:02
@veenone veenone changed the title Regrouping Hardware requested menu & requestable menu Feature - Regrouping Hardware requested menu & requestable menu Jun 17, 2022
@veenone veenone changed the title Feature - Regrouping Hardware requested menu & requestable menu [Feature] - Regrouping Hardware requested menu & requestable menu Jun 17, 2022
@snipe
Copy link
Owner

snipe commented Jun 18, 2022

I'm not sure I agree with this nav change - requestable and incoming requests are not really related in workflow. Regular users requesting items is one thing, while the incoming requests tends to be an admin only task. Most admins don't request assets for themselves, they would just check them out to themselves.

I'm open to being convinced, I'm just not sure this is the right approach. It puts the incoming requests further from the admin's asset workflow.

@veenone
Copy link
Contributor Author

veenone commented Jun 18, 2022

HI Snipe, thanks for your explanation. the fact that in for the past 3 years me and my team always do the workflow that you mentioned - they directly receive request by mail / chat and they do the checkout from the asset list directly, not knowing that there's a dedicated requested list to manage incoming requests. partially this due to the limitation on going through the documentation & language understanding barrier (my bad).

CMIIW, requested is more regularly used as operational activities compared to the rest which I think more into maintenance activities which less regularly change (again, maybe I'm wrong) so having it to be grouped with the other operational related activities would be better. by having this way I can direct specific team members to be in charge on these requestable & requested process and not to care on the other asset related menus. just these 2.

But on the other hand based on your explanation I might need to understand better on the current workflows and how to differentiate them in order to rearrange my current setup. Currently I just set 2 roles, admins who can do many things (many people) and users who can only read (people outside my team)

so far I understand what you're explaining and will check again about the ideal workflow with the tool. anyway any explanation in graphics regarding this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants