-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a MultiCompany Support alert for editing assets across multiple companies #13929
base: develop
Are you sure you want to change the base?
Conversation
This reverts commit c7ea12e.
This pull request has been linked to Shortcut Story #23680: Company not updating in Bulk Asset Edit. |
PR Summary
|
This looks nice, thank you @Godmartinz - my concern is just that if people are in the habit of doing this a lot, that could get pretty annoying to have to acknowledge that modal every time. Not sure how often do that. I've definitely heard some legitimate use cases (where people are using companies in a slightly different way) |
A "don't show again" checkbox could be desired here? |
@snipe I added an option to silence this alert if does become troublesome and not helpful to users in the settings menu (checkbox is only viewable if Full Companies Support is Enabled). which you would be directed to from the modal ![]() |
An alert has been added instead of the modal for the Full Company Support warning. Image is in the PR description. |
@@ -20,6 +20,18 @@ | |||
<p>{{ trans('admin/hardware/form.bulk_update_help') }}</p> | |||
|
|||
|
|||
<div class="callout callout-warning"> | |||
@if($settings->full_multiple_companies_support == 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @Godmartinz |
Description
This just gives a warning that the User is about to edit devices across multiple companies if Full Multiple Companies Support is enabled in the settings. This alert can also be disabled from general settings if it does not prove useful to a user.
In some cases editing multiple devices like this is whats needed, in other cases it might just be an oversight and not intended and this warning serves as a quality of life addition.
On the backend it introduces a Liverwire Component that can be reused for modals and pop-ups as needed across the project.
Fixes #SC-23680
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: