ASGI and Async support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes tests - Simplifies util functions - Fixes signal for cleanup sync requests
- Splits sync and async middleware tests into two different files - Implements async view tests with unique GUIDs - Removes URL checker from middleware into processors
- Updates README.rst to be a bit more slick
|
Sorry for the notification spam to watchers - the test matrix just won't work as I want it to. |
sondrelg
force-pushed
the
django31asgi
branch
from
92a81da to
0630e7d
Compare
JonasKs
added a commit
to snok/install-poetry
that referenced
this pull request
Oct 26, 2020
sondrelg
reviewed
Oct 27, 2020
sondrelg
requested changes
Oct 27, 2020
- Makes the logs in the API a bit more clear - Removes deprecated setting and warning - Resolves comments from @sondrelg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ASGIandasyncsupport, in other words support for the "new" modern type of Django.This PR introduces breaking changes.
This version of Django GUID (
3.0.0) requires Django3.1.1 or higher. (3.1.0 has a bug which makes it not possible to use async middlewares properly on it.)Closes #22