Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage workflow #45

Merged
merged 6 commits into from
Oct 31, 2020
Merged

Update coverage workflow #45

merged 6 commits into from
Oct 31, 2020

Conversation

sondrelg
Copy link
Member

@sondrelg sondrelg commented Oct 31, 2020

Adds install-poetry action for coverage job.

Removes the CODECOV_TOKEN parts of the codecov action in the coverage run, as it is not required to explicitly state as long as it exists in the repos secrets (see https://github.com/codecov/codecov-action)

@sondrelg sondrelg requested a review from JonasKs October 31, 2020 06:59
Copy link
Member Author

@sondrelg sondrelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with trigger on push, and seems to work OK.

@sondrelg sondrelg marked this pull request as ready for review October 31, 2020 07:06
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          197       197           
=========================================
  Hits           197       197           
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf73ed...ebb2533. Read the comment docs.

Copy link
Member

@JonasKs JonasKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice☺️ Maybe rebase?

@sondrelg sondrelg merged commit 32c7a13 into master Oct 31, 2020
@sondrelg sondrelg deleted the update-coverage-workflow branch October 31, 2020 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants