Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine test and coverage, and cache pre-commit install #68

Merged
merged 5 commits into from
Oct 25, 2021

Conversation

sondrelg
Copy link
Member

@sondrelg sondrelg commented Oct 25, 2021

Small upgrade before copying repo.

  • Combines the coverage and test workflows to deduplicate work.
  • Caches the pre-commit cache for the linting job, which cuts the runtime by ~20 sec
  • Updates the pre-commit config
  • Updates dependencies

@sondrelg sondrelg force-pushed the sondrelg/ci branch 4 times, most recently from 44c33c6 to 1599b88 Compare October 25, 2021 11:12
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #68 (487ee38) into master (37a07b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          345       343    -2     
=========================================
- Hits           345       343    -2     
Impacted Files Coverage Δ
django_guid/config.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a07b9...487ee38. Read the comment docs.

@sondrelg sondrelg marked this pull request as ready for review October 25, 2021 11:30
Copy link
Member

@JonasKs JonasKs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sondrelg sondrelg merged commit 4ad7f93 into master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants