Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Factorize code and add new tests on adding/removing triangles in TriangleSetTopology_test #5246

Closed

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jan 28, 2025

1 issue to be created:
Test testAddingTriangles reveal that method
testAddingTriangles is crashing. Check:

    // TODO @epernod (2025-01-28): Adding the triangle create a segmentation fault. Need to investigate why
    // triangleModifier->addTriangles(triangesToAdd);

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod
Copy link
Contributor Author

epernod commented Jan 28, 2025

[ci-build][with-all-tests]

@bakpaul
Copy link
Contributor

bakpaul commented Feb 3, 2025

Nice work on tests.
While you where at it, have you though about the two problems raised by this issue ? #5127
It seems that the interaction between topological changes and some forcefield are not properly working. MAybe the way they are propagated ? Do you have an idea ?

@bakpaul bakpaul added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 10, 2025
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status ready Approved a pull-request, ready to be squashed labels Feb 12, 2025
@hugtalbot hugtalbot closed this Feb 19, 2025
@epernod epernod deleted the inf_2025_02_testTriangles branch February 19, 2025 09:38
@epernod epernod removed the pr: status to review To notify reviewers to review this pull-request label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: test PR adding test(s) in SOFA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants