-
Notifications
You must be signed in to change notification settings - Fork 97
Conversation
This is really one interest feature, I will waiting for your merge! |
@@ -4,4 +4,4 @@ cd codebrag-ui | |||
nohup npm install && ./node_modules/.bin/grunt server & | |||
|
|||
cd ../ | |||
java -Dfile.encoding=UTF8 -Xmx3000M -Xss1M -XX:+CMSClassUnloadingEnabled -XX:MaxPermSize=1024m -jar sbt-launch.jar "~ container:start" | |||
java -Dfile.encoding=UTF8 -Xmx1590M -Xss1M -XX:+CMSClassUnloadingEnabled -XX:MaxPermSize=1024m -jar sbt-launch.jar "~ container:start" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you reduce this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was developing on a 32-bit machine, this has a memory limitation. But this should indeed not be part of the merge. I will revert this.
I'm wondering how to treat teamless users, showing |
teamFinder.findAllAsManagedTeamMembers(team) | ||
} else { | ||
ManagedTeamMembersListView(List.empty) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert this if
clause?
if (config.demo) {
ManagedTeamMembersListView(List.empty)
} else {
var team = teamFinder.findTeam(new ObjectId(params("teamId")));
teamFinder.findAllAsManagedTeamMembers(team)
}
The filtering of the team members seemed logical at first for an all team setup. But it indeed requires some visualisation:
|
Let's start with the simplest option - user is not assigned to any team, show everything |
- cleanup - show all users to review if not part of team
Is it ready for final shot? |
We have been using it for the past weeks now, and did not see any problems. Although addition features could be added, this is a stable first version of the 'teams' support. |
We are developing an application with about 30 developers that all contribute in the same repository. It's not interesting to review everybody's code, so I've added a team functionality.
It allows to create teams and add existing users to this team.
A team member can either be a spectator or a contributor. The commits of all the contributors are listed in the "to review" tab. Being part of a team as spectator allows you to view and comment, but other members won't be able to see your commits.
These are my initial requirements and I've limited my implementation to this. I was not sure yet on how to display it in the ui and what to do as default behavior for users that are not part of a team (nothing to review?).
Does a functionality like this require a more advanced user system or can it exist separate from the user system as I've implemented it now.