Added a comment about order of dropping plugin and library (#34160)

Added a comment about order of dropping plugin and library
solana-labs · Nov 27, 2023 · 8445246 · 8445246
1 parent a22487f
commit 8445246
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/geyser-plugin-manager/src/geyser_plugin_manager.rs b/geyser-plugin-manager/src/geyser_plugin_manager.rs
@@ -221,6 +221,7 @@ impl GeyserPluginManager {
         let mut current_plugin = self.plugins.remove(idx);
         let name = current_plugin.name().to_string();
         current_plugin.on_unload();
+        // The plugin must be dropped before the library to avoid a crash.
         drop(current_plugin);
         drop(current_lib);
         info!("Unloaded plugin {name} at idx {idx}");