Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested route with escaping resolved incorrectly (#1829) #1834

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

yinonburgansky
Copy link
Contributor

before /routes/nested/(ignored)route0.tsx resolved to nestedroute0 now it resolves to nested/route0.

PR Checklist

Please check if your PR fulfills the following requirements:

before `/routes/nested/(ignored)route0.tsx` resolved to `nestedroute0`
now it resolves to `nested/route0`.
Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: b9a25a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit b9a25a2
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/67c5e6bd08798f00089b8157
😎 Deploy Preview https://deploy-preview-1834--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@birkskyum
Copy link
Member

birkskyum commented Mar 3, 2025

Thanks!

Can you add a patch changeset? just run pnpm changeset

@yinonburgansky
Copy link
Contributor Author

Can you add a patch changeset? just run pnpm changeset

@birkskyum done

@birkskyum birkskyum merged commit ffd7cba into solidjs:main Mar 3, 2025
10 checks passed
@yinonburgansky yinonburgansky deleted the nested-route-escaping branch March 3, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Route with (...) resolved incorrectly
3 participants