Skip to content

Commit

Permalink
Fix crash when moving a container to a fullscreen workspace
Browse files Browse the repository at this point in the history
Setting normal focus to the fullscreen view causes the old workspace to
start destroying. We then set focus to the old workspace which is no
longer attached in the tree.

As we are only setting focus_inactive on the fullscreen container, the
fix uses seat_set_raw_focus to avoid all the additional behaviour that
comes with it such as destroying the old workspace.
  • Loading branch information
RyanDwyer committed Oct 22, 2018
1 parent a918844 commit f04b8f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sway/commands/move.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ static void workspace_focus_fullscreen(struct sway_workspace *workspace) {
if (focus_ws == workspace) {
struct sway_node *new_focus =
seat_get_focus_inactive(seat, &workspace->fullscreen->node);
seat_set_focus(seat, new_focus);
seat_set_raw_focus(seat, new_focus);
}
}
}
Expand Down

0 comments on commit f04b8f0

Please sign in to comment.