[HLD] orchagent for PFC Historical stats #1903
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
peterbailey-arista
force-pushed
the
master
branch
from
22db32b to
58f08f5
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
peterbailey-arista
force-pushed
the
master
branch
from
58f08f5 to
acca53d
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
peterbailey-arista
force-pushed
the
master
branch
from
acca53d to
8eadba7
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
lguohan
reviewed
Feb 25, 2025
|
|
||
| A new orch agent named "PfcHistoryOrch" will configure a flex counter group ("PFC\_STAT\_HISTORY") with a lua script plugin to poll COUNTERS\_DB at the configured interval and investigate if Pause Frames have been received on the interface. | ||
|
|
||
| `TOTAL_PAUSE_TRANSITIONS`: Running total number of transitions from unpaused to paused |
There was a problem hiding this comment.
take a look at this stats, looks like same as definition. https://github.com/sonic-net/sonic-swss/blob/master/orchagent/pfc_detect_broadcom.lua#L43
SAI_PORT_STAT_PFC_RX_PKTS
SAI_PORT_STAT_PFC_ON2OFF_RX_PKTS
There was a problem hiding this comment.
in pfc watchdog logic, looks like we are already pulling these counters at ~200ms, so you might want to just reuse those counters instead of pulling your own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally presented in SONiC Hackathon 2024
Using software to extrapolate PFC activity from existing PFC RX counters.
#1904