Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TSB is saved in config when test_startup_tsa_tsb is disabled #17247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Javier-Tan
Copy link
Contributor

@Javier-Tan Javier-Tan commented Feb 28, 2025

Description of PR

Summary:
Fixes #17246

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Make sure tsa_enabled = false when startup_tsa_tsb is disabled through pretest

How did you do it?

Add config save after TSB is executed

How did you verify/test it?

Output tsa_enabled before and after pretest to make sure it is working is intended

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

* Add config save after performing TSB in pretest

Signed-off-by: Javier Tan [email protected]
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Javier-Tan Javier-Tan requested a review from arlakshm February 28, 2025 03:16
@Javier-Tan Javier-Tan changed the title Ensure TSB is in golden config Ensure TSB is saved in config when test_startup_tsa_tsb is disabled Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug|Enhancement|Test Gap]:
2 participants