Skip to content

Commit

Permalink
fix order in release process docs
Browse files Browse the repository at this point in the history
it is important to first do all the changes that modify the release contents,
then tag/sign it, then build the binaries via vagrant.

Only then the binaries will have the correct version number.
  • Loading branch information
ThomasWaldmann committed Feb 7, 2016
1 parent 46059f0 commit 2170d6e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions docs/development.rst
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,7 @@ Checklist:
- make sure all issues for this milestone are closed or moved to the
next milestone
- find and fix any low hanging fruit left on the issue tracker
- run tox on all supported platforms via vagrant, check for test failures
- check that Travis CI is also happy
- check that Travis CI is happy
- update ``CHANGES.rst``, based on ``git log $PREVIOUS_RELEASE..``
- check version number of upcoming release in ``CHANGES.rst``
- verify that ``MANIFEST.in`` and ``setup.py`` are complete
Expand All @@ -168,6 +167,8 @@ Checklist:

git tag -s -m "tagged/signed release X.Y.Z" X.Y.Z

- run tox and/or binary builds on all supported platforms via vagrant,
check for test failures
- create a release on PyPi::

python setup.py register sdist upload --identity="Thomas Waldmann" --sign
Expand Down

0 comments on commit 2170d6e

Please sign in to comment.