forked from prestodb/presto
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix skip values with Parquet lazy reads
- Loading branch information
Showing
16 changed files
with
479 additions
and
373 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
...hive/src/main/java/com/facebook/presto/hive/parquet/reader/ParquetBinaryColumnReader.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.hive.parquet.reader; | ||
|
|
||
| import com.facebook.presto.spi.block.BlockBuilder; | ||
| import com.facebook.presto.spi.block.BlockBuilderStatus; | ||
| import io.airlift.slice.Slices; | ||
| import parquet.column.ColumnDescriptor; | ||
| import parquet.io.api.Binary; | ||
|
|
||
| import static com.facebook.presto.spi.type.VarcharType.VARCHAR; | ||
|
|
||
| public class ParquetBinaryColumnReader | ||
| extends ParquetColumnReader | ||
| { | ||
| public ParquetBinaryColumnReader(ColumnDescriptor descriptor) | ||
| { | ||
| super(descriptor); | ||
| } | ||
|
|
||
| public BlockBuilder createBlockBuilder() | ||
| { | ||
| return VARCHAR.createBlockBuilder(new BlockBuilderStatus(), this.nextBatchSize); | ||
| } | ||
|
|
||
| @Override | ||
| public void readValues(BlockBuilder blockBuilder, int valueNumber) | ||
| { | ||
| for (int i = 0; i < valueNumber; i++) { | ||
| if (this.definitionReader.readLevel() == this.columnDescriptor.getMaxDefinitionLevel()) { | ||
| Binary binary = valuesReader.readBytes(); | ||
| if (binary.length() == 0) { | ||
| VARCHAR.writeSlice(blockBuilder, Slices.EMPTY_SLICE); | ||
| } | ||
| else { | ||
| VARCHAR.writeSlice(blockBuilder, Slices.wrappedBuffer(binary.getBytes())); | ||
| } | ||
| } | ||
| else { | ||
| blockBuilder.appendNull(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void skipValues(int offsetNumber) | ||
| { | ||
| for (int i = 0; i < offsetNumber; i++) { | ||
| if (this.definitionReader.readLevel() == this.columnDescriptor.getMaxDefinitionLevel()) { | ||
| this.valuesReader.readBytes(); | ||
| } | ||
| } | ||
| } | ||
| } |
57 changes: 57 additions & 0 deletions
57
...ive/src/main/java/com/facebook/presto/hive/parquet/reader/ParquetBooleanColumnReader.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.hive.parquet.reader; | ||
|
|
||
| import com.facebook.presto.spi.block.BlockBuilder; | ||
| import com.facebook.presto.spi.block.BlockBuilderStatus; | ||
| import parquet.column.ColumnDescriptor; | ||
|
|
||
| import static com.facebook.presto.spi.type.BooleanType.BOOLEAN; | ||
|
|
||
| public class ParquetBooleanColumnReader | ||
| extends ParquetColumnReader | ||
| { | ||
| public ParquetBooleanColumnReader(ColumnDescriptor descriptor) | ||
| { | ||
| super(descriptor); | ||
| } | ||
|
|
||
| public BlockBuilder createBlockBuilder() | ||
| { | ||
| return BOOLEAN.createBlockBuilder(new BlockBuilderStatus(), this.nextBatchSize); | ||
| } | ||
|
|
||
| @Override | ||
| public void readValues(BlockBuilder blockBuilder, int valueNumber) | ||
| { | ||
| for (int i = 0; i < valueNumber; i++) { | ||
| if (this.definitionReader.readLevel() == this.columnDescriptor.getMaxDefinitionLevel()) { | ||
| BOOLEAN.writeBoolean(blockBuilder, this.valuesReader.readBoolean()); | ||
| } | ||
| else { | ||
| blockBuilder.appendNull(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void skipValues(int offsetNumber) | ||
| { | ||
| for (int i = 0; i < offsetNumber; i++) { | ||
| if (this.definitionReader.readLevel() == this.columnDescriptor.getMaxDefinitionLevel()) { | ||
| this.valuesReader.readBoolean(); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.