Add preconditions

soscpd · Oct 18, 2012 · d1e1448 · d1e1448
1 parent 7835cbc
commit d1e1448
Show file tree

Hide file tree

Showing 21 changed files with 68 additions and 0 deletions.
diff --git a/src/main/java/com/facebook/presto/sql/tree/AliasedRelation.java b/src/main/java/com/facebook/presto/sql/tree/AliasedRelation.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 import java.util.List;
 
@@ -13,6 +14,9 @@ public class AliasedRelation
 
     public AliasedRelation(Relation relation, String alias, List<String> columnNames)
     {
+        Preconditions.checkNotNull(relation, "relation is null");
+        Preconditions.checkNotNull(alias, " is null");
+
         this.relation = relation;
         this.alias = alias;
         this.columnNames = columnNames;

diff --git a/src/main/java/com/facebook/presto/sql/tree/BetweenPredicate.java b/src/main/java/com/facebook/presto/sql/tree/BetweenPredicate.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class BetweenPredicate
         extends Expression
@@ -11,6 +12,10 @@ public class BetweenPredicate
 
     public BetweenPredicate(Expression value, Expression min, Expression max)
     {
+        Preconditions.checkNotNull(value, "value is null");
+        Preconditions.checkNotNull(min, "min is null");
+        Preconditions.checkNotNull(max, "max is null");
+
         this.value = value;
         this.min = min;
         this.max = max;

diff --git a/src/main/java/com/facebook/presto/sql/tree/CoalesceExpression.java b/src/main/java/com/facebook/presto/sql/tree/CoalesceExpression.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 
 import java.util.List;
@@ -12,6 +13,8 @@ public class CoalesceExpression
 
     public CoalesceExpression(List<Expression> operands)
     {
+        Preconditions.checkNotNull(operands, "operands is null");
+
         this.operands = ImmutableList.copyOf(operands);
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/ComparisonExpression.java b/src/main/java/com/facebook/presto/sql/tree/ComparisonExpression.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class ComparisonExpression
         extends Expression
@@ -32,6 +33,10 @@ public String getValue()
 
     public ComparisonExpression(Type type, Expression left, Expression right)
     {
+        Preconditions.checkNotNull(type, "type is null");
+        Preconditions.checkNotNull(left, "left is null");
+        Preconditions.checkNotNull(right, "right is null");
+
         this.type = type;
         this.left = left;
         this.right = right;

diff --git a/src/main/java/com/facebook/presto/sql/tree/DateLiteral.java b/src/main/java/com/facebook/presto/sql/tree/DateLiteral.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class DateLiteral
         extends Literal
@@ -9,6 +10,7 @@ public class DateLiteral
 
     public DateLiteral(String value)
     {
+        Preconditions.checkNotNull(value, "value is null");
         this.value = value;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/DoubleLiteral.java b/src/main/java/com/facebook/presto/sql/tree/DoubleLiteral.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class DoubleLiteral
         extends Literal
@@ -9,6 +10,7 @@ public class DoubleLiteral
 
     public DoubleLiteral(String value)
     {
+        Preconditions.checkNotNull(value, "value is null");
         this.value = value;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/ExistsPredicate.java b/src/main/java/com/facebook/presto/sql/tree/ExistsPredicate.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class ExistsPredicate
         extends Expression
@@ -9,6 +10,7 @@ public class ExistsPredicate
 
     public ExistsPredicate(Query subquery)
     {
+        Preconditions.checkNotNull(subquery, "subquery is null");
         this.subquery = subquery;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/IntervalLiteral.java b/src/main/java/com/facebook/presto/sql/tree/IntervalLiteral.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class IntervalLiteral
         extends Literal
@@ -16,6 +17,9 @@ public enum Sign
 
     public IntervalLiteral(String value, String type, Sign sign)
     {
+        Preconditions.checkNotNull(value, "value is null");
+        Preconditions.checkNotNull(type, "type is null");
+
         this.value = value;
         this.type = type;
         this.sign = sign;

diff --git a/src/main/java/com/facebook/presto/sql/tree/IsNotNullPredicate.java b/src/main/java/com/facebook/presto/sql/tree/IsNotNullPredicate.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class IsNotNullPredicate
         extends Expression
@@ -9,6 +10,7 @@ public class IsNotNullPredicate
 
     public IsNotNullPredicate(Expression value)
     {
+        Preconditions.checkNotNull(value, "value is null");
         this.value = value;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/IsNullPredicate.java b/src/main/java/com/facebook/presto/sql/tree/IsNullPredicate.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class IsNullPredicate
         extends Expression
@@ -9,6 +10,7 @@ public class IsNullPredicate
 
     public IsNullPredicate(Expression value)
     {
+        Preconditions.checkNotNull(value, "value is null");
         this.value = value;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/Join.java b/src/main/java/com/facebook/presto/sql/tree/Join.java
@@ -1,12 +1,16 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class Join
         extends Relation
 {
     public Join(Type type, Relation left, Relation right, JoinCriteria criteria)
     {
+        Preconditions.checkNotNull(left, "left is null");
+        Preconditions.checkNotNull(right, "right is null");
+
         this.type = type;
         this.left = left;
         this.right = right;

diff --git a/src/main/java/com/facebook/presto/sql/tree/LikePredicate.java b/src/main/java/com/facebook/presto/sql/tree/LikePredicate.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class LikePredicate
         extends Expression
@@ -10,6 +11,9 @@ public class LikePredicate
     private final Expression escape;
 
     public LikePredicate(Expression value, Expression pattern, Expression escape) {
+        Preconditions.checkNotNull(value, "value is null");
+        Preconditions.checkNotNull(pattern, "pattern is null");
+
         this.value = value;
         this.pattern = pattern;
         this.escape = escape;

diff --git a/src/main/java/com/facebook/presto/sql/tree/LogicalBinaryExpression.java b/src/main/java/com/facebook/presto/sql/tree/LogicalBinaryExpression.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class LogicalBinaryExpression
         extends Expression
@@ -16,6 +17,10 @@ public enum Type
 
     public LogicalBinaryExpression(Type type, Expression left, Expression right)
     {
+        Preconditions.checkNotNull(type, "type is null");
+        Preconditions.checkNotNull(left, "left is null");
+        Preconditions.checkNotNull(right, "right is null");
+
         this.type = type;
         this.left = left;
         this.right = right;

diff --git a/src/main/java/com/facebook/presto/sql/tree/LongLiteral.java b/src/main/java/com/facebook/presto/sql/tree/LongLiteral.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class LongLiteral
         extends Literal
@@ -9,6 +10,7 @@ public class LongLiteral
 
     public LongLiteral(String value)
     {
+        Preconditions.checkNotNull(value, "value is null");
         this.value = value;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/NotExpression.java b/src/main/java/com/facebook/presto/sql/tree/NotExpression.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class NotExpression
         extends Expression
@@ -9,6 +10,7 @@ public class NotExpression
 
     public NotExpression(Expression value)
     {
+        Preconditions.checkNotNull(value, "value is null");
         this.value = value;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/Query.java b/src/main/java/com/facebook/presto/sql/tree/Query.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 import java.util.List;
 
@@ -24,6 +25,12 @@ public Query(
             List<SortItem> orderBy,
             String limit)
     {
+        Preconditions.checkNotNull(select, "select is null");
+        Preconditions.checkNotNull(from, "from is null");
+        Preconditions.checkArgument(!from.isEmpty(), "from is empty");
+        Preconditions.checkNotNull(groupBy, "groupBy is null");
+        Preconditions.checkNotNull(orderBy, "orderBy is null");
+
         this.select = select;
         this.from = from;
         this.where = where;

diff --git a/src/main/java/com/facebook/presto/sql/tree/SearchedCaseExpression.java b/src/main/java/com/facebook/presto/sql/tree/SearchedCaseExpression.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 
 import java.util.List;
@@ -13,6 +14,7 @@ public class SearchedCaseExpression
 
     public SearchedCaseExpression(List<WhenClause> whenClauses, Expression defaultValue)
     {
+        Preconditions.checkNotNull(whenClauses, "whenClauses is null");
         this.whenClauses = ImmutableList.copyOf(whenClauses);
         this.defaultValue = defaultValue;
     }

diff --git a/src/main/java/com/facebook/presto/sql/tree/SimpleCaseExpression.java b/src/main/java/com/facebook/presto/sql/tree/SimpleCaseExpression.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 
 import java.util.List;
@@ -14,6 +15,9 @@ public class SimpleCaseExpression
 
     public SimpleCaseExpression(Expression operand, List<WhenClause> whenClauses, Expression defaultValue)
     {
+        Preconditions.checkNotNull(operand, "operand is null");
+        Preconditions.checkNotNull(whenClauses, "whenClauses is null");
+
         this.operand = operand;
         this.whenClauses = ImmutableList.copyOf(whenClauses);
         this.defaultValue = defaultValue;

diff --git a/src/main/java/com/facebook/presto/sql/tree/StringLiteral.java b/src/main/java/com/facebook/presto/sql/tree/StringLiteral.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class StringLiteral
         extends Literal
@@ -9,6 +10,7 @@ public class StringLiteral
 
     public StringLiteral(String value)
     {
+        Preconditions.checkNotNull(value, "value is null");
         this.value = value;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/TimeLiteral.java b/src/main/java/com/facebook/presto/sql/tree/TimeLiteral.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class TimeLiteral
         extends Literal
@@ -9,6 +10,7 @@ public class TimeLiteral
 
     public TimeLiteral(String value)
     {
+        Preconditions.checkNotNull(value, "value is null");
         this.value = value;
     }
 

diff --git a/src/main/java/com/facebook/presto/sql/tree/TimestampLiteral.java b/src/main/java/com/facebook/presto/sql/tree/TimestampLiteral.java
@@ -1,6 +1,7 @@
 package com.facebook.presto.sql.tree;
 
 import com.google.common.base.Objects;
+import com.google.common.base.Preconditions;
 
 public class TimestampLiteral
         extends Literal
@@ -9,6 +10,8 @@ public class TimestampLiteral
 
     public TimestampLiteral(String value)
     {
+        Preconditions.checkNotNull(value, "value is null");
+
         this.value = value;
     }