string interning of QualifiedName
#2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienhenry
previously approved these changes
Dec 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2451 +/- ##
==========================================
+ Coverage 77.75% 77.86% +0.11%
==========================================
Files 474 481 +7
Lines 31164 31935 +771
==========================================
+ Hits 24232 24867 +635
- Misses 6932 7068 +136
|
fix perf issue in RecursiveClauses
julienhenry
approved these changes
Dec 8, 2023
quentin
added a commit
to quentin/souffle
that referenced
this pull request
Jun 19, 2024
String interning of `QualifiedName` and switch many associative datastructures to unordered comparison between qualified name. These comparisons had a significant cost on large datalog programs. A global `QNInterner` object is responsible for interning of qualified names. Also fix a performance issue in the `RecursiveClauses` analysis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String interning of
QualifiedNameand switch many associative datastructures to unordered comparison between qualified name. These comparisons had a significant cost on large datalog programs.A global
QNInternerobject is responsible for interning of qualified names.Also fix a performance issue in the
RecursiveClausesanalysis.