Skip to content

Commit

Permalink
mm/vmstat.c: convert to use DEFINE_SEQ_ATTRIBUTE macro
Browse files Browse the repository at this point in the history
Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code.

Signed-off-by: Kefeng Wang <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Cc: Anil S Keshavamurthy <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Greg KH <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Al Viro <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Kefeng Wang authored and torvalds committed Jun 5, 2020
1 parent d2c0e6e commit 01a9956
Showing 1 changed file with 6 additions and 26 deletions.
32 changes: 6 additions & 26 deletions mm/vmstat.c
Original file line number Diff line number Diff line change
Expand Up @@ -2069,24 +2069,14 @@ static int unusable_show(struct seq_file *m, void *arg)
return 0;
}

static const struct seq_operations unusable_op = {
static const struct seq_operations unusable_sops = {
.start = frag_start,
.next = frag_next,
.stop = frag_stop,
.show = unusable_show,
};

static int unusable_open(struct inode *inode, struct file *file)
{
return seq_open(file, &unusable_op);
}

static const struct file_operations unusable_file_ops = {
.open = unusable_open,
.read = seq_read,
.llseek = seq_lseek,
.release = seq_release,
};
DEFINE_SEQ_ATTRIBUTE(unusable);

static void extfrag_show_print(struct seq_file *m,
pg_data_t *pgdat, struct zone *zone)
Expand Down Expand Up @@ -2121,24 +2111,14 @@ static int extfrag_show(struct seq_file *m, void *arg)
return 0;
}

static const struct seq_operations extfrag_op = {
static const struct seq_operations extfrag_sops = {
.start = frag_start,
.next = frag_next,
.stop = frag_stop,
.show = extfrag_show,
};

static int extfrag_open(struct inode *inode, struct file *file)
{
return seq_open(file, &extfrag_op);
}

static const struct file_operations extfrag_file_ops = {
.open = extfrag_open,
.read = seq_read,
.llseek = seq_lseek,
.release = seq_release,
};
DEFINE_SEQ_ATTRIBUTE(extfrag);

static int __init extfrag_debug_init(void)
{
Expand All @@ -2147,10 +2127,10 @@ static int __init extfrag_debug_init(void)
extfrag_debug_root = debugfs_create_dir("extfrag", NULL);

debugfs_create_file("unusable_index", 0444, extfrag_debug_root, NULL,
&unusable_file_ops);
&unusable_fops);

debugfs_create_file("extfrag_index", 0444, extfrag_debug_root, NULL,
&extfrag_file_ops);
&extfrag_fops);

return 0;
}
Expand Down

0 comments on commit 01a9956

Please sign in to comment.