ARC: mm: do_page_fault refactor #2: remove short lived variable

Compiler will do this anyways, still.. No functional change. Signed-off-by: Vineet Gupta <[email protected]>
soumdtt · Jul 1, 2019 · 13e2cc1 · 13e2cc1
1 parent 450e5b6
commit 13e2cc1
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/arch/arc/mm/fault.c b/arch/arc/mm/fault.c
@@ -64,23 +64,18 @@ void do_page_fault(unsigned long address, struct pt_regs *regs)
 	struct task_struct *tsk = current;
 	struct mm_struct *mm = tsk->mm;
 	int si_code = SEGV_MAPERR;
-	int ret;
 	vm_fault_t fault;
 	int write = regs->ecr_cause & ECR_C_PROTV_STORE;  /* ST/EX */
 	unsigned int flags = FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE;
 
 	/*
-	 * We fault-in kernel-space virtual memory on-demand. The
-	 * 'reference' page table is init_mm.pgd.
-	 *
 	 * NOTE! We MUST NOT take any locks for this case. We may
 	 * be in an interrupt or a critical region, and should
 	 * only copy the information from the master page table,
 	 * nothing more.
 	 */
 	if (address >= VMALLOC_START && !user_mode(regs)) {
-		ret = handle_kernel_vaddr_fault(address);
-		if (unlikely(ret))
+		if (unlikely(handle_kernel_vaddr_fault(address)))
 			goto no_context;
 		else
 			return;