Skip to content

Commit

Permalink
smp, metag: kill SMP single function call interrupt
Browse files Browse the repository at this point in the history
Commit 9a46ad6 "smp: make smp_call_function_many() use logic
similar to smp_call_function_single()" has unified the way to handle
single and multiple cross-CPU function calls. Now only one interrupt is
needed for architecture specific code to support generic SMP function
call interfaces, so kill the redundant single function call interrupt.

Signed-off-by: Jiang Liu <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Shaohua Li <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Jiri Kosina <[email protected]>
Signed-off-by: James Hogan <[email protected]>
  • Loading branch information
jiangliu authored and James Hogan committed Dec 5, 2013
1 parent 5a25f7b commit 1d61cf1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
2 changes: 0 additions & 2 deletions arch/metag/include/asm/smp.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@

enum ipi_msg_type {
IPI_CALL_FUNC,
IPI_CALL_FUNC_SINGLE,
IPI_RESCHEDULE,
};

extern void arch_send_call_function_single_ipi(int cpu);
extern void arch_send_call_function_ipi_mask(const struct cpumask *mask);
#define arch_send_call_function_ipi_mask arch_send_call_function_ipi_mask

asmlinkage void secondary_start_kernel(void);

Expand Down
6 changes: 1 addition & 5 deletions arch/metag/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ void arch_send_call_function_ipi_mask(const struct cpumask *mask)

void arch_send_call_function_single_ipi(int cpu)
{
send_ipi_message(cpumask_of(cpu), IPI_CALL_FUNC_SINGLE);
send_ipi_message(cpumask_of(cpu), IPI_CALL_FUNC);
}

void show_ipi_list(struct seq_file *p)
Expand Down Expand Up @@ -545,10 +545,6 @@ static int do_IPI(void)
generic_smp_call_function_interrupt();
break;

case IPI_CALL_FUNC_SINGLE:
generic_smp_call_function_single_interrupt();
break;

default:
pr_crit("CPU%u: Unknown IPI message 0x%lx\n",
cpu, nextmsg);
Expand Down

0 comments on commit 1d61cf1

Please sign in to comment.