net: slcan, slip -- no need for goto when if () will do

No need to play with gotos to jump over single statement. Signed-off-by: Pavel Machek <[email protected]> Acked-by: Oliver Hartkopp <[email protected]> Signed-off-by: David S. Miller <[email protected]>
soumdtt · Mar 12, 2020 · dacf470 · dacf470
1 parent c7211ff
commit dacf470
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c
@@ -348,11 +348,8 @@ static void slcan_write_wakeup(struct tty_struct *tty)
 
 	rcu_read_lock();
 	sl = rcu_dereference(tty->disc_data);
-	if (!sl)
-		goto out;
-
-	schedule_work(&sl->tx_work);
-out:
+	if (sl)
+		schedule_work(&sl->tx_work);
 	rcu_read_unlock();
 }
 

diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
@@ -456,11 +456,8 @@ static void slip_write_wakeup(struct tty_struct *tty)
 
 	rcu_read_lock();
 	sl = rcu_dereference(tty->disc_data);
-	if (!sl)
-		goto out;
-
-	schedule_work(&sl->tx_work);
-out:
+	if (sl)
+		schedule_work(&sl->tx_work);
 	rcu_read_unlock();
 }